Fix a crash bug in assert

zsuraski · zsuraski · commit e629be7b5b95 · 2001-07-31T02:59:44.000Z
diff --git a/ext/standard/assert.c b/ext/standard/assert.c
@@ -54,14 +54,15 @@ static PHP_INI_MH(OnChangeCallback)
 {
 	if (ASSERTG(callback)) {
 		zval_ptr_dtor(&ASSERTG(callback));
-	} else {
-		MAKE_STD_ZVAL(ASSERTG(callback));
 	}
 
-	if (new_value)
-		ZVAL_STRINGL(ASSERTG(callback),new_value,new_value_length,1)
-	else
-		ZVAL_EMPTY_STRING(ASSERTG(callback))
+	MAKE_STD_ZVAL(ASSERTG(callback));
+
+	if (new_value) {
+		ZVAL_STRINGL(ASSERTG(callback),new_value,new_value_length,1);
+	} else {
+		ZVAL_EMPTY_STRING(ASSERTG(callback));
+	}
 
 	return SUCCESS;
 }
