Fixed a bug in the new implementation of str_repeat()

Sander Roobol · Sander Roobol · commit e6e2c1c70d45 · 2002-10-04T17:10:51.000Z
diff --git a/ext/standard/string.c b/ext/standard/string.c
@@ -3582,8 +3582,8 @@ PHP_FUNCTION(str_repeat)
 	result_len = Z_STRLEN_PP(input_str) * Z_LVAL_PP(mult);
 	result = (char *)emalloc(result_len + 1);
 	
-	/* Heavy optimization for situations where multiplier is 1 byte long */
-	if (Z_LVAL_PP(mult) == 1) {
+	/* Heavy optimization for situations where input string is 1 byte long */
+	if (Z_STRLEN_PP(input_str) == 1) {
 		memset(result, *(Z_STRVAL_PP(input_str)), Z_LVAL_PP(mult)); 
 	} else {
 		char *s, *e, *ee;
