fix: rclone cat needs to pass through stdio

sntran · sntran · commit 6ac8659ef501 · 2021-03-13T13:39:50.000-06:00
diff --git a/bin/rclone.js b/bin/rclone.js
@@ -4,7 +4,7 @@ const rclone = require("../");
 
 const [/** node **/, /** file **/, commandName, ...args] = process.argv;
 
-// "update" command is not a rclone command.
+// "update" is not a rclone command.
 if (commandName === "update") {
   return rclone.update(...args);
 }
@@ -14,10 +14,10 @@ const { [commandName]: command } = rclone;
 
 const subprocess = command ? command(...args) : rclone(commandName, ...args);
 
-subprocess.stdout.on("data", (data) => {
+subprocess.stdout?.on("data", (data) => {
   console.log(data.toString());
 });
 
-subprocess.stderr.on("data", (data) => {
+subprocess.stderr?.on("data", (data) => {
   console.error(data.toString());
 });
diff --git a/index.js b/index.js
@@ -77,11 +77,17 @@ api.update = async function() {
   });
 }
 
+// Rclone's `cat` needs to pipe directly to stdout.
+api.cat = function() {
+  return spawn(RCLONE, ["cat", ...arguments], {
+    stdio: "inherit",
+  });
+}
+
 const COMMANDS = [
   "about", // Get quota information from the remote.
   "authorize", // Remote authorization.
   "backend", // Run a backend specific command.
-  "cat", // Concatenates any files and sends them to stdout.
   "check", // Checks the files in the source and destination match.
   "cleanup", // Clean up the remote if possible.
   "config", // Enter an interactive configuration session.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rclone.js",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "JavaScript API for rclone",
   "main": "index.js",
   "bin": {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rclone.js",`
`3`		`- "version": "0.4.1",`
	`3`	`+ "version": "0.4.2",`
`4`	`4`	`"description": "JavaScript API for rclone",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"bin": {`