Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 90fb0a9
Choose a base ref
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 24b847b
Choose a head ref
  • 19 commits
  • 17 files changed
  • 8 contributors

Commits on Feb 17, 2022

  1. Configuration menu
    Copy the full SHA
    a463d26 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. fix(uws): properly handle chunked content (#642)

    With the engine based on µWebSockets.js (introduced in version 6.1.0),
    a huge request body split in multiple chunks would throw the following
    error:
    
    > node:buffer:254
    >   TypedArrayPrototypeSet(target, source, targetStart);
    >   ^
    >
    > TypeError: Cannot perform %TypedArray%.prototype.set on a detached ArrayBuffer
    >     at Buffer.set (<anonymous>)
    >     at _copyActual (node:buffer:254:3)
    > node:buffer:254
    >   TypedArrayPrototypeSet(target, source, targetStart);
    >   ^
    >
    > TypeError: Cannot perform %TypedArray%.prototype.set on a detached ArrayBuffer
    >     at Buffer.set (<anonymous>)
    >     at _copyActual (node:buffer:254:3)
    >     at Function.concat (node:buffer:562:12)
    >     at onEnd (.../node_modules/engine.io/build/transports-uws/polling.js:126:32)
    >     at .../node_modules/engine.io/build/transports-uws/polling.js:143:17
    
    Note: µWebSockets.js does not currently support chunked transfer
    encoding.
    e3dio authored and darrachequesne committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    3367440 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5df4f18 View commit details
    Browse the repository at this point in the history
  3. chore: bump engine.io-parser to version 5.0.3

    In order to make sure the types added in [1] are included.
    
    Related:
    
    - #639
    - #640
    
    [1]: socketio/engine.io-parser@ad5bd7d
    darrachequesne committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    1bc5b1a View commit details
    Browse the repository at this point in the history
  4. chore(release): 6.1.3

    darrachequesne committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    ce3fe9d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. refactor: return an HTTP 413 response for too large payloads

    Before this, the connection was closed abrutly with an HTTP 502
    response.
    
    See also: f8100f9
    
    Related: socketio/socket.io#4293
    darrachequesne committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    e24b27b View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Configuration menu
    Copy the full SHA
    657f04e View commit details
    Browse the repository at this point in the history
  2. feat: add the "maxPayload" field in the handshake details

    So that clients in HTTP long-polling can decide how many packets they
    have to send to stay under the maxHttpBufferSize value.
    
    This is a backward compatible change which should not mandate a new
    major revision of the protocol (we stay in v4), as we only add a field
    in the JSON-encoded handshake data:
    
    ```
    0{"sid":"lv_VI97HAXpY6yYWAAAC","upgrades":["websocket"],"pingInterval":25000,"pingTimeout":5000,"maxPayload":1000000}
    ```
    
    Related: socketio/socket.io-client#1531
    darrachequesne committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    088dcb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2022

  1. chore(release): 6.2.0

    darrachequesne committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    d7e3ab7 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Configuration menu
    Copy the full SHA
    ed1d6f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Configuration menu
    Copy the full SHA
    020801a View commit details
    Browse the repository at this point in the history
  2. refactor: replace deprecated String.prototype.substr() (#646)

    `.substr()` is deprecated so we replace it with `.slice()` which works
    similarily but isn't deprecated.
    
    See also: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr
    
    Signed-off-by: Lam Wei Li <peteriman@mail.com>
    lamweili authored Jun 6, 2022
    Configuration menu
    Copy the full SHA
    917d1d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Configuration menu
    Copy the full SHA
    1b71a6f View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. ci: add Node.js 18 in the test matrix

    A few notes:
    
    - the certificates were recreated because Node.js 18 includes OpenSSL
    v3, which has deprecated support for some legacy ciphers (like RC2)
    
    - eiows currently fails to build on Node.js 18, so the tests are
    temporarily skipped
    
    See also: https://github.com/nodejs/Release
    darrachequesne committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    535a01d View commit details
    Browse the repository at this point in the history
  2. chore(deps): bump nanoid from 3.1.25 to 3.3.1 (#659)

    Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.25 to 3.3.1.
    - [Release notes](https://github.com/ai/nanoid/releases)
    - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
    - [Commits](ai/nanoid@3.1.25...3.3.1)
    
    ---
    updated-dependencies:
    - dependency-name: nanoid
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 19, 2022
    Configuration menu
    Copy the full SHA
    7c1270f View commit details
    Browse the repository at this point in the history
  3. chore(deps): bump minimatch from 3.0.4 to 3.1.2 (#660)

    Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
    - [Release notes](https://github.com/isaacs/minimatch/releases)
    - [Commits](isaacs/minimatch@v3.0.4...v3.1.2)
    
    ---
    updated-dependencies:
    - dependency-name: minimatch
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 19, 2022
    Configuration menu
    Copy the full SHA
    d196f6a View commit details
    Browse the repository at this point in the history
  4. chore(deps): bump xmlhttprequest-ssl and engine.io-client in /example…

    …s/latency (#661)
    
    Bumps [xmlhttprequest-ssl](https://github.com/mjwwit/node-XMLHttpRequest) to 1.6.3 and updates ancestor dependency [engine.io-client](https://github.com/socketio/engine.io-client). These dependencies need to be updated together.
    
    
    Updates `xmlhttprequest-ssl` from 1.5.5 to 1.6.3
    - [Release notes](https://github.com/mjwwit/node-XMLHttpRequest/releases)
    - [Commits](mjwwit/node-XMLHttpRequest@1.5.5...1.6.3)
    
    Updates `engine.io-client` from 4.0.0 to 4.1.4
    - [Release notes](https://github.com/socketio/engine.io-client/releases)
    - [Changelog](https://github.com/socketio/engine.io-client/blob/main/CHANGELOG.md)
    - [Commits](socketio/engine.io-client@4.0.0...4.1.4)
    
    ---
    updated-dependencies:
    - dependency-name: xmlhttprequest-ssl
      dependency-type: indirect
    - dependency-name: engine.io-client
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 19, 2022
    Configuration menu
    Copy the full SHA
    99adb00 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. fix: catch errors when destroying invalid upgrades (#658)

    Before this change, receiving an HTTP2 upgrade would make the server
    crash:
    
    > Error: read ECONNRESET
    >    at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {
    >  errno: -104,
    >  code: 'ECONNRESET',
    >  syscall: 'read'
    > }
    
    This can be reproduced with Node.js v14.15.3, v16.18.1 and v18.12.1.
    jonathanneve authored and darrachequesne committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    425e833 View commit details
    Browse the repository at this point in the history
  2. chore(release): 6.2.1

    darrachequesne committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    24b847b View commit details
    Browse the repository at this point in the history
Loading