Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-adapter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.5.3
Choose a base ref
...
head repository: socketio/socket.io-adapter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.5.4
Choose a head ref
  • 7 commits
  • 8 files changed
  • 1 contributor

Commits on Feb 22, 2024

  1. fix(types): ensure compatibility with TypeScript < 4.5 

    "import { type ... }" was added in TypeScript 4.5.

Reference: https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/

Related:

- #86
- socketio/socket.io#3891
    @darrachequesne
    darrachequesne committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ca397f3 View commit details
    Browse the repository at this point in the history

  2. refactor(cluster): export ClusterAdapterOptions and MessageType types 

    Related:

- https://github.com/socketio/socket.io-redis-streams-adapter/blob/89d00a49e4aadf1bfe32ddc644d0ef877a08238d/lib/adapter.ts#L17
- https://github.com/socketio/socket.io-redis-streams-adapter/blob/89d00a49e4aadf1bfe32ddc644d0ef877a08238d/lib/adapter.ts#L191
    @darrachequesne
    darrachequesne committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    9d4c4a7 View commit details
    Browse the repository at this point in the history

  3. refactor: break circular dependency (1) 

    This will be done in two steps, in order to preserve the history of the
index.ts file.
    @darrachequesne
    darrachequesne committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    abc93a9 View commit details
    Browse the repository at this point in the history

  4. refactor: break circular dependency (2)

    @darrachequesne
    darrachequesne committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    207c0db View commit details
    Browse the repository at this point in the history

  5. fix: ensure the order of the commands 

    Before this change, the broadcast() method would send the BROADCAST
command and then apply it locally (which is required to retrieve the
offset of the message, when connection state recovery is enabled),
while the other commands like disconnectSockets() would first apply it
locally and then send the command to the other nodes.

So, for example:

```js
io.emit("bye");
io.disconnectSockets();
```

In that case, the clients connected to the io instance would not receive
the "bye" event, while the clients connected to the other server
instances would receive it before being disconnected.

Related:

- socketio/socket.io-redis-streams-adapter#13
- socketio/socket.io-postgres-adapter#12
    @darrachequesne
    darrachequesne committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a13f35f View commit details
    Browse the repository at this point in the history

  6. ci: test with older TypeScript version

    @darrachequesne
    darrachequesne committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    005d546 View commit details
    Browse the repository at this point in the history

  7. chore(release): 2.5.4 

    Diff: 2.5.3...2.5.4
    @darrachequesne
    darrachequesne committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5eae5a0 View commit details
    Browse the repository at this point in the history
Loading