-
Notifications
You must be signed in to change notification settings - Fork 107
Comparing changes
Open a pull request
base repository: socketio/socket.io-parser
base: 4.2.1
head repository: socketio/socket.io-parser
compare: 4.2.3
- 11 commits
- 15 files changed
- 3 contributors
Commits on Nov 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f0af883 - Browse repository at this point
Copy the full SHA f0af883View commit details
Commits on Nov 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a9758da - Browse repository at this point
Copy the full SHA a9758daView commit details -
ci: migrate from zuul to webdriver.io
zuul is now archived [1] and does not support the new W3C WebDriver protocol, since it relies on the wd package [2] under the hood, which uses the (now deprecated) JSON Wire Protocol. We will now use the webdriver.io test framework, which allows to run our tests in local and on Sauce Labs (cross-browser and mobile tests). This allows us to run our tests on latest versions of Android and iOS, since Sauce Labs only supports the W3C WebDriver protocol for these platforms ([3]). [1]: https://github.com/defunctzombie/zuul [2]: https://github.com/admc/wd [3]: https://docs.saucelabs.com/dev/w3c-webdriver-capabilities/
Configuration menu - View commit details
-
Copy full SHA for 194a9b7 - Browse repository at this point
Copy the full SHA 194a9b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9143aa4 - Browse repository at this point
Copy the full SHA 9143aa4View commit details
Commits on Jan 19, 2023
-
fix: do not modify the input packet upon encoding
Note: this issue has existed since Socket.IO v1.0 (see [1]), because the `deconstructPacket()` method also mutates its input argument. This also explains why some adapters (like [2]) need to use `process.nextTick()` when extending the `broadcast()` method, because `Adapter.broadcast()` calls `Encoder.encode()` ([3]). Related: - socketio/socket.io#4374 - socketio/socket.io-mongo-adapter#10 [1]: 299849b [2]: https://github.com/socketio/socket.io-postgres-adapter/blob/0.3.0/lib/index.ts#L587-L590 [3]: https://github.com/socketio/socket.io-adapter/blob/2.4.0/lib/index.ts#L148
Configuration menu - View commit details
-
Copy full SHA for ae8dd88 - Browse repository at this point
Copy the full SHA ae8dd88View commit details -
fix: calling destroy() should clear all internal state
If a client was in the process of receiving some binary attachments when the connection was abruptly closed, then the manager would call `decoder.destroy()` ([1]) but was then stuck in a "parse error" loop upon reconnection (since it expected a binary attachment and not a CONNECT packet). [1]: https://github.com/socketio/socket.io-client/blob/a1c528b089773d7810a03befaeb982f7e01c3e11/lib/manager.ts#L520
Configuration menu - View commit details
-
Copy full SHA for 22c42e3 - Browse repository at this point
Copy the full SHA 22c42e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28dd668 - Browse repository at this point
Copy the full SHA 28dd668View commit details
Commits on Jan 25, 2023
-
chore: bump ua-parser-js from 1.0.32 to 1.0.33 (#121)
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 1.0.32 to 1.0.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@1.0.32...1.0.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0841bd5 - Browse repository at this point
Copy the full SHA 0841bd5View commit details
Commits on May 22, 2023
-
fix: check the format of the event name
A packet like '2[{"toString":"foo"}]' was decoded as: { type: EVENT, data: [ { "toString": "foo" } ] } Which would then throw an error when passed to the EventEmitter class: > TypeError: Cannot convert object to primitive value > at Socket.emit (node:events:507:25) > at .../node_modules/socket.io/lib/socket.js:531:14 History of the isPayloadValid() method: - added in [78f9fc2](78f9fc2) (v4.0.1, socket.io@3.0.0) - updated in [1c220dd](1c220dd) (v4.0.4, socket.io@3.1.0)
2Configuration menu - View commit details
-
Copy full SHA for 3b78117 - Browse repository at this point
Copy the full SHA 3b78117View commit details -
refactor: export typescript declarations for the commonjs build
Related: socketio/socket.io#4621 (comment)
Configuration menu - View commit details
-
Copy full SHA for dcc70d9 - Browse repository at this point
Copy the full SHA dcc70d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6c824f - Browse repository at this point
Copy the full SHA b6c824fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.2.1...4.2.3