From 1c220ddbf45ea4b44bc8dbf6f9ae245f672ba1b9 Mon Sep 17 00:00:00 2001 From: Damien Arrachequesne Date: Fri, 15 Jan 2021 01:38:03 +0100 Subject: [PATCH 1/2] fix: allow integers as event names This commit restores the possibility to use integers as event names, which was possible in Socket.IO v2. --- lib/index.ts | 2 +- test/parser.js | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/index.ts b/lib/index.ts index 587dd54..636df23 100644 --- a/lib/index.ts +++ b/lib/index.ts @@ -245,7 +245,7 @@ export class Decoder extends Emitter { return typeof payload === "string" || typeof payload === "object"; case PacketType.EVENT: case PacketType.BINARY_EVENT: - return Array.isArray(payload) && typeof payload[0] === "string"; + return Array.isArray(payload) && payload.length > 0; case PacketType.ACK: case PacketType.BINARY_ACK: return Array.isArray(payload); diff --git a/test/parser.js b/test/parser.js index 0554d93..426e77c 100644 --- a/test/parser.js +++ b/test/parser.js @@ -47,6 +47,17 @@ describe("parser", () => { ); }); + it("encodes an event (with an integer as event name)", (done) => { + helpers.test( + { + type: PacketType.EVENT, + data: [1, "a", {}], + nsp: "/", + }, + done + ); + }); + it("encodes an event (with ack)", (done) => { helpers.test( { From af1b23ca85fb64a0d7a050abd0362c5f632ce429 Mon Sep 17 00:00:00 2001 From: Damien Arrachequesne Date: Fri, 15 Jan 2021 01:45:17 +0100 Subject: [PATCH 2/2] chore(release): 4.0.4 Diff: https://github.com/socketio/socket.io-parser/compare/4.0.3...4.0.4 --- CHANGELOG.md | 8 ++++++++ package-lock.json | 2 +- package.json | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1dae8dd..11984ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,11 @@ +## [4.0.4](https://github.com/socketio/socket.io-parser/compare/4.0.3...4.0.4) (2021-01-15) + + +### Bug Fixes + +* allow integers as event names ([1c220dd](https://github.com/socketio/socket.io-parser/commit/1c220ddbf45ea4b44bc8dbf6f9ae245f672ba1b9)) + + ## [4.0.3](https://github.com/socketio/socket.io-parser/compare/4.0.2...4.0.3) (2021-01-05) diff --git a/package-lock.json b/package-lock.json index 3a2f1ce..fa41f9d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "socket.io-parser", - "version": "4.0.3", + "version": "4.0.4", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 646bf45..f15f403 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "socket.io-parser", - "version": "4.0.3", + "version": "4.0.4", "description": "socket.io protocol parser", "repository": { "type": "git",