improve checks in stream? for http1 (#58)

zarqman · web-flow · commit fd57e55c65e4 · 2023-08-30T10:38:14.000+12:00
diff --git a/.mailmap b/.mailmap
@@ -1,2 +1,3 @@
 Juan Antonio Martín Lucas <dev@jaml.pro>
 Aurora Nockert <aurora@aventine.se>
+Thomas Morgan <tm@iprog.com>
diff --git a/lib/async/websocket/upgrade_request.rb b/lib/async/websocket/upgrade_request.rb
@@ -20,9 +20,10 @@ class UpgradeRequest < ::Protocol::HTTP::Request
 			include ::Protocol::WebSocket::Headers
 			
 			class Wrapper
-				def initialize(response)
+				def initialize(response, verified:)
 					@response = response
 					@stream = nil
+					@verified = verified
 				end
 				
 				def close
@@ -32,7 +33,7 @@ def close
 				attr_accessor :response
 				
 				def stream?
-					@response.status == 101
+					@response.status == 101 && @verified
 				end
 				
 				def status
@@ -74,7 +75,7 @@ def call(connection)
 					end
 				end
 				
-				return Wrapper.new(response)
+				return Wrapper.new(response, verified: !!accept_digest)
 			end
 		end
 	end
diff --git a/test/async/websocket/client.rb b/test/async/websocket/client.rb
@@ -110,6 +110,34 @@
 	with 'http/1' do
 		let(:protocol) {Async::HTTP::Protocol::HTTP1}
 		it_behaves_like ClientExamples
+		
+		with 'invalid sec-websocket-accept header' do
+			let(:app) do
+				Protocol::HTTP::Middleware.for do |request|
+					Protocol::HTTP::Response[101, {'sec-websocket-accept'=>'wrong-digest'}, []]
+				end
+			end
+			
+			it 'raises an error' do
+				expect do
+					Async::WebSocket::Client.connect(client_endpoint) {}
+				end.to raise_exception(Async::WebSocket::ProtocolError, message: be =~ /Invalid accept digest/)
+			end
+		end
+			
+		with 'missing sec-websocket-accept header' do
+			let(:app) do
+				Protocol::HTTP::Middleware.for do |request|
+					Protocol::HTTP::Response[101, {}, []]
+				end
+			end
+			
+			it 'raises an error' do
+				expect do
+					Async::WebSocket::Client.connect(client_endpoint) {}
+				end.to raise_exception(Async::WebSocket::ProtocolError, message: be =~ /Failed to negotiate connection/)
+			end
+		end
 	end
 	
 	with 'http/2' do

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`Juan Antonio Martín Lucas <dev@jaml.pro>`
`2`	`2`	`Aurora Nockert <aurora@aventine.se>`
	`3`	`+Thomas Morgan <tm@iprog.com>`