Allow interruption of IO waits. #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
722783e to
a887d85
Compare
a887d85 to
3bcae5b
Compare
|
No longer required, it's an implicit part of the scheduler hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby's IO model allows
IO#closeto interrupt all pendingread/write/waitoperations. The Fiber Scheduler did not adopt this model initially, but after some time it's finally caused some compatibility issues for code which expects signalling betweenIO#closeand in-flight operations (to be forcefully interrupted).This introduces the changes required to support IO interrupting, by passing the IO instance to the
rb_io_interruptable_operation, which doesn't exist yet, such that any kind of interruption within Ruby can propagate out.Types of Changes
Contribution