Parse update properly with identity full - Fixes porsager#296

porsager · porsager · commit 3ed11e77e48f · 2022-03-31T08:46:09.000+02:00
diff --git a/src/subscribe.js b/src/subscribe.js
@@ -180,7 +180,7 @@ function parse(x, state, parsers, handle) {
         ? {}
         : null
 
-      old && (i = tuples(x, old, key ? relation.keys : relation.columns, ++i))
+      old && (i = tuples(x, old, key ? relation.keys : relation.columns, i += 3))
 
       const row = {}
       i = tuples(x, row, relation.columns, i += 3)
diff --git a/tests/index.js b/tests/index.js
@@ -1712,8 +1712,8 @@ t('subscribe', { timeout: 2 }, async() => {
 
   const result = []
 
-  await sql.subscribe('*', (row, info) =>
-    result.push(info.command, row.name || row.id)
+  await sql.subscribe('*', (row, { command, old }) =>
+    result.push(command, row.name || row.id, old && old.name)
   )
 
   await sql`
@@ -1722,12 +1722,17 @@ t('subscribe', { timeout: 2 }, async() => {
       name text
     )
   `
+
+  await sql`insert into test (name) values ('Murray')`
+  await sql`update test set name = 'Rothbard'`
+  await sql`delete from test`
+  await sql`alter table test replica identity full`
   await sql`insert into test (name) values ('Murray')`
   await sql`update test set name = 'Rothbard'`
   await sql`delete from test`
   await delay(100)
   return [
-    'insert,Murray,update,Rothbard,delete,1',
+    'insert,Murray,,update,Rothbard,,delete,1,,insert,Murray,,update,Rothbard,Murray,delete,Rothbard,',
     result.join(','),
     await sql`drop table test`,
     await sql`drop publication alltables`,
