chore: fix race when expecting parameters (coder#6814)

kylecarbs · web-flow · commit ffb4cd5962a4 · 2023-03-27T14:18:33.000-05:00
See https://github.com/coder/coder/actions/runs/4532378002/jobs/7983840014
diff --git a/provisioner/terraform/resources_test.go b/provisioner/terraform/resources_test.go
@@ -380,10 +380,11 @@ func TestConvertResources(t *testing.T) {
 				require.NoError(t, err)
 				require.Equal(t, expectedNoMetadataMap, resourcesMap)
 
-				if expected.parameters == nil {
-					expected.parameters = []*proto.RichParameter{}
+				expectedParams := expected.parameters
+				if expectedParams == nil {
+					expectedParams = []*proto.RichParameter{}
 				}
-				parametersWant, err := json.Marshal(expected.parameters)
+				parametersWant, err := json.Marshal(expectedParams)
 				require.NoError(t, err)
 				parametersGot, err := json.Marshal(state.Parameters)
 				require.NoError(t, err)
