Change message type requirement from str to bytes for clarity and prep for python3

Dana Powers · Dana Powers · commit 3ec3989ca1ef · 2014-09-04T12:14:45.000-07:00
diff --git a/kafka/producer.py b/kafka/producer.py
@@ -156,11 +156,11 @@ def send_messages(self, topic, partition, *msg):
         Helper method to send produce requests
         @param: topic, name of topic for produce request -- type str
         @param: partition, partition number for produce request -- type int
-        @param: *msg, one or more message payloads -- type str
+        @param: *msg, one or more message payloads -- type bytes
         @returns: ResponseRequest returned by server
         raises on error
 
-        Note that msg type *must* be encoded to str by user.
+        Note that msg type *must* be encoded to bytes by user.
         Passing unicode message will not work, for example
         you should encode before calling send_messages via
         something like `unicode_message.encode('utf-8')`
@@ -172,9 +172,9 @@ def send_messages(self, topic, partition, *msg):
         if not isinstance(msg, (list, tuple)):
             raise TypeError("msg is not a list or tuple!")
 
-        # Raise TypeError if any message is not encoded as a str
-        if any(not isinstance(m, str) for m in msg):
-            raise TypeError("all produce message payloads must be type str")
+        # Raise TypeError if any message is not encoded as bytes
+        if any(not isinstance(m, bytes) for m in msg):
+            raise TypeError("all produce message payloads must be type bytes")
 
         if self.async:
             for m in msg:
