Merge pull request dpkp#222 from dpkp/fix_socket_timeout_test

wizzat · wizzat · commit 9856cc36d774 · 2014-09-04T12:03:22.000-07:00
Fix socket timeout test -- mock the side_effect
diff --git a/test/test_client.py b/test/test_client.py
@@ -1,3 +1,5 @@
+import socket
+from time import sleep
 import unittest2
 
 from mock import MagicMock, patch
@@ -6,10 +8,14 @@
 from kafka.common import (
     ProduceRequest, BrokerMetadata, PartitionMetadata,
     TopicAndPartition, KafkaUnavailableError,
-    LeaderUnavailableError, PartitionUnavailableError
+    LeaderUnavailableError, PartitionUnavailableError,
+    ConnectionError
 )
+from kafka.conn import KafkaConnection
 from kafka.protocol import create_message
 
+from test.testutil import Timer
+
 class TestKafkaClient(unittest2.TestCase):
     def test_init_with_list(self):
         with patch.object(KafkaClient, 'load_metadata_for_topics'):
@@ -242,3 +248,15 @@ def test_send_produce_request_raises_when_noleader(self, protocol, conn):
         with self.assertRaises(LeaderUnavailableError):
             client.send_produce_request(requests)
 
+    def test_timeout(self):
+        def _timeout(*args, **kwargs):
+            timeout = args[1]
+            sleep(timeout)
+            raise socket.timeout
+
+        with patch.object(socket, "create_connection", side_effect=_timeout):
+
+            with Timer() as t:
+                with self.assertRaises(ConnectionError):
+                    KafkaConnection("nowhere", 1234, 1.0)
+            self.assertGreaterEqual(t.interval, 1.0)
diff --git a/test/test_client_integration.py b/test/test_client_integration.py
@@ -24,17 +24,6 @@ def tearDownClass(cls):  # noqa
         cls.server.close()
         cls.zk.close()
 
-    @unittest2.skip("This doesn't appear to work on Linux?")
-    def test_timeout(self):
-        server_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-        server_port = get_open_port()
-        server_socket.bind(('localhost', server_port))
-
-        with Timer() as t:
-            with self.assertRaises((socket.timeout, socket.error)):
-                kafka.conn.KafkaConnection("localhost", server_port, 1.0)
-        self.assertGreaterEqual(t.interval, 1.0)
-
     @kafka_versions("all")
     def test_consume_none(self):
         fetch = FetchRequest(self.topic, 0, 0, 1024)
