Skip to content

Make any borders introduced when rescaling images to thumbnails transparent #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Jan 18, 2021

Rescaling the images down to thumbnails often results in image borders that are white. Changing the alpha value here modifies these borders to be transparent, so that any border areas from the rescaling take on the background color of the thumbnail. This is an enhancement for users who want to use custom thumbnail background colors.

Rescaling the images down to thumbnails often results in
image borders that are white. Changing the alpha value here
modifies these borders to be transparent, so that any border
areas from the rescaling take on the background color of the
thumbnail.
rossbar added a commit to rossbar/sphinx-gallery that referenced this pull request Jan 19, 2021
Copy link
Contributor

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @larsoner I'll let you merge just in case I missed something

@larsoner larsoner merged commit cb0e1d4 into sphinx-gallery:master Jan 19, 2021
@larsoner
Copy link
Contributor

Thanks @rossbar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants