From 526e5d7dc86e29d27b143a0d84a18d1726c86ef8 Mon Sep 17 00:00:00 2001 From: akaila-splunk Date: Thu, 18 Nov 2021 14:23:30 +0530 Subject: [PATCH 1/2] Removed strip() method from data.py file - removed strip() method in load_value() method, so now response value contain leading and trailing spaces while printing data in console --- splunklib/data.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/splunklib/data.py b/splunklib/data.py index dedbb3310..f9ffb8692 100644 --- a/splunklib/data.py +++ b/splunklib/data.py @@ -161,8 +161,8 @@ def load_value(element, nametable=None): text = element.text if text is None: return None - text = text.strip() - if len(text) == 0: + + if len(text.strip()) == 0: return None return text From ec76d1e96a342f83618ab7d0cea5d749db1bc790 Mon Sep 17 00:00:00 2001 From: akaila-splunk Date: Tue, 23 Nov 2021 11:33:11 +0530 Subject: [PATCH 2/2] Update test_storage_passwords.py - added test case for check spaces in username --- tests/test_storage_passwords.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/test_storage_passwords.py b/tests/test_storage_passwords.py index 59840b794..4f2fee81f 100644 --- a/tests/test_storage_passwords.py +++ b/tests/test_storage_passwords.py @@ -222,6 +222,16 @@ def test_delete(self): self.storage_passwords.delete(username + "/foo", "/myrealm") self.assertEqual(start_count, len(self.storage_passwords)) + def test_spaces_in_username(self): + start_count = len(self.storage_passwords) + realm = testlib.tmpname() + username = " user1 " + + p = self.storage_passwords.create("changeme", username, realm) + self.assertEqual(p.username, username) + + p.delete() + self.assertEqual(start_count, len(self.storage_passwords)) if __name__ == "__main__": try: