Skip to content

Commit d25f656

Browse files
committed
Fix content warning issues over https
When served with HTTP/2 and TLS, project pages show several mixed content errors: * the imported Google fonts * the AJAX call to spring.io to get the current project information * the newsletter iframe This commit changes URLs to use https or protocol-relative URLs when possible. This also deletes the now defunct newsletter integration.
1 parent 8227656 commit d25f656

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

_config.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ custom_gradle_template: false
3232

3333
### The following properties are constant for most projects
3434

35-
main_site_url: http://spring.io
36-
projects_site_url: http://projects.spring.io
37-
questions_url: http://spring.io/questions
35+
main_site_url: https://spring.io
36+
projects_site_url: https://projects.spring.io
37+
questions_url: https://spring.io/questions

_includes/page.html

+4-10
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<link rel="icon" type="image/png" href="{{site.baseurl}}/favicon.png"/>
55

66
<link rel="stylesheet" type="text/css" href="{{site.baseurl}}/bootstrap/css/bootstrap.min.css" />
7-
<link href='http://fonts.googleapis.com/css?family=Varela+Round|Montserrat:400,700' rel='stylesheet' type='text/css'>
7+
<link href='//fonts.googleapis.com/css?family=Varela+Round|Montserrat:400,700' rel='stylesheet' type='text/css'>
88
<link rel="stylesheet" type="text/css" href="{{site.baseurl}}/font-awesome/css/font-awesome.min.css" />
99
<link rel="stylesheet" type="text/css" href="{{site.baseurl}}/bootstrap/css/bootstrap-select.css" />
1010

@@ -114,15 +114,9 @@
114114
</div>
115115
</div>
116116
&copy; <script type="text/javascript"> var d = new Date();
117-
document.write(d.getFullYear());</script> <a href="http://www.pivotal.io">Pivotal Software</a>, Inc. All Rights Reserved.
118-
<a href="http://www.pivotal.io/terms-of-use">Terms of Use</a> and
119-
<a href="http://www.pivotal.io/privacy-policy">Privacy</a>
120-
</div>
121-
<div class="span4 footer-newsletter--wrapper pull-right">
122-
<div class="footer-newsletter--container">
123-
<label>Subscribe to our newsletter</label>
124-
<iframe frameborder="0" height="42px" scrolling="no" src="http://play.gopivotal.com/OSS_Website_Spring_SpringNewsletterSubscriptionEmailOnly.html" style="border:none" width="324px"></iframe>
125-
</div>
117+
document.write(d.getFullYear());</script> <a href="https://www.pivotal.io">Pivotal Software</a>, Inc. All Rights Reserved.
118+
<a href="https://www.pivotal.io/terms-of-use">Terms of Use</a> and
119+
<a href="https://www.pivotal.io/privacy-policy">Privacy</a>
126120
</div>
127121
</div>
128122
</div>

0 commit comments

Comments
 (0)