Skip to content

Commit 22272b8

Browse files
kyleconroykyleconroy
authored
fix(engine/mysql): Update incorrect signatures (#1180)
DATE_ADD and DATE_SUB take three arguments, not two.
1 parent f4d1414 commit 22272b8

File tree

9 files changed

+212
-0
lines changed

9 files changed

+212
-0
lines changed

‎internal/endtoend/testdata/mysql_reference_manual/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
All queries and examples in this directory come from the [MySQL Reference
2+
Manual](https://dev.mysql.com/doc/refman/8.0/en/).

‎internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/date_add.sql

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
-- https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-add
2+
3+
-- name: DateAddOneDay :one
4+
SELECT DATE_ADD('2018-05-01',INTERVAL 1 DAY);
5+
6+
-- name: DateAddOneSecond :one
7+
SELECT DATE_ADD('2020-12-31 23:59:59',
8+
INTERVAL 1 SECOND);
9+
10+
-- name: DateAddTimestampOneSecond :one
11+
SELECT DATE_ADD('2018-12-31 23:59:59',
12+
INTERVAL 1 DAY);
13+
14+
-- name: DateAddMinuteSecond :one
15+
SELECT DATE_ADD('2100-12-31 23:59:59',
16+
INTERVAL '1:1' MINUTE_SECOND);
17+
18+
-- name: DateAddDayHour :one
19+
SELECT DATE_ADD('1900-01-01 00:00:00',
20+
INTERVAL '-1 10' DAY_HOUR);
21+
22+
-- name: DateAddSecondMicrosecond :one
23+
SELECT DATE_ADD('1992-12-31 23:59:59.000002',
24+
INTERVAL '1.999999' SECOND_MICROSECOND);

‎internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/date_sub.sql

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
-- name: DateSubOneYear :one
2+
SELECT DATE_SUB('2018-05-01',INTERVAL 1 YEAR);
3+
4+
-- name: DateSubDaySecond :one
5+
SELECT DATE_SUB('2025-01-01 00:00:00',
6+
INTERVAL '1 1:1:1' DAY_SECOND);
7+
8+
-- name: DateSub31Days :one
9+
SELECT DATE_SUB('1998-01-02', INTERVAL 31 DAY);

‎internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/date_add.sql.go

Lines changed: 82 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/date_sub.sql.go

Lines changed: 43 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/db.go

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/models.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/mysql_reference_manual/sqlc.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"version": "1",
3+
"packages": [
4+
{
5+
"name": "date_and_time_functions",
6+
"path": "date_and_time_functions/go",
7+
"schema": "date_and_time_functions",
8+
"queries": "date_and_time_functions",
9+
"engine": "mysql"
10+
}
11+
]
12+
}

‎internal/engine/dolphin/stdlib.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -630,6 +630,9 @@ func defaultSchema(name string) *catalog.Schema {
630630
{
631631
Type: &ast.TypeName{Name: "any"},
632632
},
633+
{
634+
Type: &ast.TypeName{Name: "any"},
635+
},
633636
},
634637
ReturnType: &ast.TypeName{Name: "date"},
635638
},
@@ -666,6 +669,9 @@ func defaultSchema(name string) *catalog.Schema {
666669
{
667670
Type: &ast.TypeName{Name: "any"},
668671
},
672+
{
673+
Type: &ast.TypeName{Name: "any"},
674+
},
669675
},
670676
ReturnType: &ast.TypeName{Name: "date"},
671677
},

0 commit comments

Comments
 (0)