Skip to content

Commit 7ff8e6f

Browse files
authored
fix(engine/sqlite): Lowercase ast.ResTarget.Name (#2433)
* fix(engine/sqlite): To lowercase ast.ResTarget.Name The SQLite engine lowercases ast.ResTarget.Name to match the behavior of pg_query. fix #2120 * test: add endtoend * chore: v1.19.1
1 parent e7ab328 commit 7ff8e6f

File tree

6 files changed

+90
-3
lines changed

6 files changed

+90
-3
lines changed

internal/endtoend/testdata/case_sensitive/sqlite/go/db.go

Lines changed: 31 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/case_sensitive/sqlite/go/models.go

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/case_sensitive/sqlite/go/query.sql.go

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
CREATE TABLE contacts (
2+
pid TEXT,
3+
CustomerName TEXT
4+
);
5+
6+
-- name: InsertContact :exec
7+
INSERT INTO contacts (
8+
pid,
9+
CustomerName
10+
)
11+
VALUES (?,?)
12+
;
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"version": "1", "packages": [{"path": "go", "engine": "sqlite", "schema": "query.sql", "queries": "query.sql", "name": "querytest"}]}

internal/engine/sqlite/convert.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ func (c *cc) getCols(core *parser.Select_coreContext) []ast.Node {
493493
}
494494

495495
if col.AS_() != nil {
496-
name := col.Column_alias().GetText()
496+
name := identifier(col.Column_alias().GetText())
497497
target.Name = &name
498498
}
499499

@@ -805,7 +805,7 @@ func (c *cc) convertExprLists(lists []parser.IExprContext) *ast.List {
805805
func (c *cc) convertColumnNames(cols []parser.IColumn_nameContext) *ast.List {
806806
list := &ast.List{Items: []ast.Node{}}
807807
for _, c := range cols {
808-
name := c.GetText()
808+
name := identifier(c.GetText())
809809
list.Items = append(list.Items, &ast.ResTarget{
810810
Name: &name,
811811
})
@@ -912,7 +912,7 @@ func (c *cc) convertUpdate_stmtContext(n Update_stmt) ast.Node {
912912

913913
list := &ast.List{}
914914
for i, col := range n.AllColumn_name() {
915-
colName := col.GetText()
915+
colName := identifier(col.GetText())
916916
target := &ast.ResTarget{
917917
Name: &colName,
918918
Val: c.convert(n.Expr(i)),

0 commit comments

Comments
 (0)