Skip to content

Commit c2224b9

Browse files
committed
Fix route configs to use name instead of as
1 parent 8ce373e commit c2224b9

File tree

3 files changed

+20
-24
lines changed

3 files changed

+20
-24
lines changed

ng-sample/.vscode/launch.json

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,83 +6,79 @@
66
"type": "nativescript",
77
"platform": "ios",
88
"request": "launch",
9-
"appRoot": ".",
9+
"appRoot": "${workspaceRoot}",
1010
"sourceMaps": true,
11-
"diagnosticLogging": true,
12-
"stopOnEntry": true,
11+
"diagnosticLogging": false,
1312
"emulator": false
1413
},
1514
{
1615
"name": "Attach on iOS Device",
1716
"type": "nativescript",
1817
"platform": "ios",
1918
"request": "attach",
20-
"appRoot": ".",
19+
"appRoot": "${workspaceRoot}",
2120
"sourceMaps": true,
22-
"diagnosticLogging": true,
21+
"diagnosticLogging": false,
2322
"emulator": false
2423
},
2524
{
2625
"name": "Launch on iOS Emulator",
2726
"type": "nativescript",
2827
"platform": "ios",
2928
"request": "launch",
30-
"appRoot": ".",
29+
"appRoot": "${workspaceRoot}",
3130
"sourceMaps": true,
32-
"diagnosticLogging": true,
33-
"stopOnEntry": true,
31+
"diagnosticLogging": false,
3432
"emulator": true
3533
},
3634
{
3735
"name": "Attach on iOS Emulator",
3836
"type": "nativescript",
3937
"platform": "ios",
4038
"request": "attach",
41-
"appRoot": ".",
39+
"appRoot": "${workspaceRoot}",
4240
"sourceMaps": true,
43-
"diagnosticLogging": true,
41+
"diagnosticLogging": false,
4442
"emulator": true
4543
},
4644
{
4745
"name": "Launch on Android Device",
4846
"type": "nativescript",
4947
"platform": "android",
5048
"request": "launch",
51-
"appRoot": ".",
49+
"appRoot": "${workspaceRoot}",
5250
"sourceMaps": true,
53-
"diagnosticLogging": true,
54-
"stopOnEntry": true,
51+
"diagnosticLogging": false,
5552
"emulator": false
5653
},
5754
{
5855
"name": "Launch on Android Emulator",
5956
"type": "nativescript",
6057
"platform": "android",
6158
"request": "launch",
62-
"appRoot": ".",
59+
"appRoot": "${workspaceRoot}",
6360
"sourceMaps": true,
64-
"diagnosticLogging": true,
65-
"stopOnEntry": true,
61+
"diagnosticLogging": false,
6662
"emulator": true
6763
},
6864
{
6965
"name": "Attach on Android Device",
7066
"type": "nativescript",
7167
"platform": "android",
7268
"request": "attach",
73-
"appRoot": ".",
69+
"appRoot": "${workspaceRoot}",
7470
"sourceMaps": false,
75-
"diagnosticLogging": true,
71+
"diagnosticLogging": false,
7672
"emulator": false
7773
},
7874
{
7975
"name": "Attach on Android Emulator",
8076
"type": "nativescript",
8177
"platform": "android",
8278
"request": "attach",
83-
"appRoot": ".",
79+
"appRoot": "${workspaceRoot}",
8480
"sourceMaps": false,
85-
"diagnosticLogging": true,
81+
"diagnosticLogging": false,
8682
"emulator": true
8783
}
8884
]

ng-sample/app/examples/action-bar/action-bar-test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ class SecondComponent {
8383
`
8484
})
8585
@RouteConfig([
86-
{ path: '/', component: FirstComponent, as: 'First' },
87-
{ path: '/second', component: SecondComponent, as: 'Second' },
86+
{ path: '/', component: FirstComponent, name: 'First' },
87+
{ path: '/second', component: SecondComponent, name: 'Second' },
8888
])
8989
export class ActionBarTest {
9090
}

ng-sample/app/examples/navigation/navigation-test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ class StartComponent {
3434
template: `<page-router-outlet></page-router-outlet>`
3535
})
3636
@RouteConfig([
37-
{ path: '/', component: StartComponent, as: 'Start' },
38-
{ path: '/nav/:depth/...', component: NavComponent, as: 'Nav' },
37+
{ path: '/', component: StartComponent, name: 'Start' },
38+
{ path: '/nav/:depth/...', component: NavComponent, name: 'Nav' },
3939
])
4040
export class NavigationTest {
4141

0 commit comments

Comments
 (0)