fixes for mutable default parameters in dataframe

eman · eman · commit b32807115bc7 · 2016-12-03T10:15:58.000-08:00
diff --git a/influxdb/_dataframe_client.py b/influxdb/_dataframe_client.py
@@ -44,8 +44,8 @@ def write_points(self,
                      dataframe,
                      measurement,
                      tags=None,
-                     tag_columns=[],
-                     field_columns=[],
+                     tag_columns=None,
+                     field_columns=None,
                      time_precision=None,
                      database=None,
                      retention_policy=None,
@@ -72,6 +72,10 @@ def write_points(self,
             figures for float and all significant figures for int datatypes.
 
         """
+        if tag_columns is None:
+            tag_columns = []
+        if field_columns is None:
+            field_columns = []
         if batch_size:
             number_batches = int(math.ceil(len(dataframe) / float(batch_size)))
             for batch in range(number_batches):
@@ -166,8 +170,8 @@ def _convert_dataframe_to_json(self,
                                    dataframe,
                                    measurement,
                                    tags=None,
-                                   tag_columns=[],
-                                   field_columns=[],
+                                   tag_columns=None,
+                                   field_columns=None,
                                    time_precision=None):
 
         if not isinstance(dataframe, pd.DataFrame):
@@ -179,9 +183,9 @@ def _convert_dataframe_to_json(self,
                             PeriodIndex.')
 
         # Make sure tags and tag columns are correctly typed
-        tag_columns = tag_columns if tag_columns else []
-        field_columns = field_columns if field_columns else []
-        tags = tags if tags else {}
+        tag_columns = tag_columns if tag_columns is not None else []
+        field_columns = field_columns if field_columns is not None else []
+        tags = tags if tags is not None else {}
         # Assume field columns are all columns not included in tag columns
         if not field_columns:
             field_columns = list(
@@ -221,8 +225,8 @@ def _convert_dataframe_to_json(self,
     def _convert_dataframe_to_lines(self,
                                     dataframe,
                                     measurement,
-                                    field_columns=[],
-                                    tag_columns=[],
+                                    field_columns=None,
+                                    tag_columns=None,
                                     global_tags={},
                                     time_precision=None,
                                     numeric_precision=None):
@@ -242,6 +246,8 @@ def _convert_dataframe_to_lines(self,
             field_columns = []
         if tag_columns is None:
             tag_columns = []
+        if global_tags is None:
+            global_tags = {}
 
         # Make sure field_columns and tag_columns are lists
         field_columns = list(field_columns) if list(field_columns) else []
