Skip to content

WIP: Extend column mgmt for general conditional columns #16356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dv/ROX-30477-replace-redux-for-metadata
Choose a base branch
from
Draft

WIP: Extend column mgmt for general conditional columns #16356

wants to merge 1 commit into from

Conversation

dvail
Copy link
Contributor

@dvail dvail commented Aug 8, 2025 •
edited
Loading

Description

Expands the usage of column management to allow cleaner conditional rendering of table columns in Vuln Management.

This will help us to use these tables in the OCP dynamic plugin, which has different column requirements, without requiring us to do any of the following:

  • Duplicate Table code
  • Abstract our current patterns to use column descriptors instead of direct rendering (massive refactor)
  • Add additional boolean flag props to handle condition columns

In addition to avoiding the previous items there are a couple of side benefits to this approach:

  • Existing boolean props and permission checks can be removed or de-duplicated, and moved to the parent component
  • All table columns are now explicit in the config and can simplify the calculation of colSpan
  • Conditional rendering in the table is replaced with the getVisibilityClass helper, which is already in use and consolidates the multiple render patterns

Follow ups

  1. I had to add eslint suppressions for our custom lint rule related to this pattern - it would be better to expand this to support the new cases if possible

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Existing thorough tests at the unit and e2e level regarding column management in VM 🙏

Manual testing with feature flags, etc. (screenshots TBD)

@dvail
Copy link
Contributor Author

dvail commented Aug 8, 2025 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail force-pushed the dv/ROX-30477-replace-redux-for-metadata branch from a1cccef to 9b91975 Compare August 8, 2025 16:32
@dvail dvail mentioned this pull request Aug 8, 2025
Open
9 tasks
@dvail dvail force-pushed the dv/use-column-mgmt-for-conditional-columns branch 2 times, most recently from 12024f5 to 9343f39 Compare August 8, 2025 16:48
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.12%. Comparing base (9b91975) to head (302a952).

Additional details and impacted files 
@@                           Coverage Diff                            @@
##           dv/ROX-30477-replace-redux-for-metadata   #16356   +/-   ##
========================================================================
  Coverage                                    49.12%   49.12%           
========================================================================
  Files                                         2632     2632           
  Lines                                       195130   195130           
========================================================================
  Hits                                         95862    95862           
  Misses                                       91770    91770           
  Partials                                      7498     7498
Flag Coverage Δ
go-unit-tests 49.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail force-pushed the dv/use-column-mgmt-for-conditional-columns branch from 9343f39 to 302a952 Compare August 8, 2025 20:01
@dvail
Copy link
Contributor Author

dvail commented Aug 8, 2025

/test gke-ui-e2e-tests

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 8, 2025

@dvail: No presubmit jobs available for stackrox/stackrox@dv/ROX-30477-replace-redux-for-metadata

In response to this:

/test gke-ui-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/central area/sensor area/ui do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dvail