Skip to content

ROX-29938, ROX-29939: remove search and count funcs #16358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: dashrews/searcher-remove-cve-edge-searchers-30407
Choose a base branch
from

Conversation

dashrews78
Copy link
Contributor

getting started

remove searchers

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Copy link

openshift-ci bot commented Aug 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Aug 8, 2025

Images are ready for the commit at 9cccc0f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-495-g9cccc0f488.

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.03%. Comparing base (fc7cb5a) to head (9cccc0f).

Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           dashrews/searcher-remove-cve-edge-searchers-30407   #16358      +/-   ##
=====================================================================================
+ Coverage                                              49.02%   49.03%   +0.01%     
=====================================================================================
  Files                                                   2634     2633       -1     
  Lines                                                 195487   195331     -156     
=====================================================================================
- Hits                                                   95841    95785      -56     
+ Misses                                                 92150    92050     -100     
  Partials                                                7496     7496              
Flag Coverage Δ
go-unit-tests 49.03% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dashrews78 dashrews78 force-pushed the dashrews/searcher-remove-cve-edge-searchers-30407 branch from f91c343 to fc7cb5a Compare August 12, 2025 17:21
@dashrews78 dashrews78 force-pushed the dashrews/searcher-remove-count-search-func-29938-29939 branch from eacd26a to 9cccc0f Compare August 12, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants