Skip to content

refactor(ui): Migrate NetworkGraph components from deprecated select #16359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: saif/select-migration-pt-3
Choose a base branch
from

Conversation

sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Aug 8, 2025

fix

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Copy link

openshift-ci bot commented Aug 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 05ace11.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-464-g67cf582de9.

Copy link

codecov bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.11%. Comparing base (fcde18e) to head (9e34d27).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           saif/select-migration-pt-3   #16359      +/-   ##
==============================================================
+ Coverage                       49.04%   49.11%   +0.06%     
==============================================================
  Files                            2635     2634       -1     
  Lines                          195367   195187     -180     
==============================================================
+ Hits                            95820    95867      +47     
+ Misses                          92047    91823     -224     
+ Partials                         7500     7497       -3     
Flag Coverage Δ
go-unit-tests 49.11% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sachaudh sachaudh force-pushed the saif/select-migration-pt-3 branch from 0ede271 to 8d79746 Compare August 12, 2025 16:16
@sachaudh sachaudh force-pushed the saif/select-migration-pt-4 branch 7 times, most recently from 6dab890 to f87028e Compare August 12, 2025 21:27
@sachaudh sachaudh force-pushed the saif/select-migration-pt-3 branch from 06d810b to fcde18e Compare August 13, 2025 02:27
@sachaudh sachaudh force-pushed the saif/select-migration-pt-4 branch from f87028e to d71b6e9 Compare August 13, 2025 02:28
@sachaudh
Copy link
Contributor Author

/test-e2e

@sachaudh sachaudh force-pushed the saif/select-migration-pt-4 branch from b4231cb to 9e34d27 Compare August 13, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants