Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

Commit e0ec86d

Browse files
committed
Remove final few stragglers of _get_attribute
1 parent ac8c1b6 commit e0ec86d

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

github3/issues/event.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def _update_attributes(self, event):
6868
self.commit_url = event['commit_url']
6969
self.created_at = event['created_at']
7070
self.event = event['event']
71-
self.id = self._get_attribute(event, 'id')
71+
self.id = event['id']
7272
self._uniq = self.commit_id
7373

7474
def _repr(self):

github3/repos/pages.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class PagesBuild(models.GitHubCore):
7474

7575
def _update_attributes(self, build):
7676
from .. import users
77-
self._api = self._get_attribute(build, 'url')
77+
self._api = build['url']
7878
self.commit = build['commit']
7979
self.created_at = self._strptime(build['created_at'])
8080
self.duration = build['duration']

github3/repos/stats.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class ContributorStats(models.GitHubCore):
7676
def _update_attributes(self, stats_object):
7777
self.author = users.ShortUser(stats_object['author'], self)
7878
self.total = stats_object['total']
79-
self.weeks = self._get_attribute(stats_object, 'weeks', [])
79+
self.weeks = stats_object['weeks']
8080
alt_weeks = self.weeks
8181
if alt_weeks:
8282
alt_weeks = [alternate_week(w) for w in self.weeks]

github3/repos/status.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,11 @@ def _update_attributes(self, combined_status):
144144
self.repository = repo.ShortRepository(
145145
combined_status['repository'], self,
146146
)
147-
self.sha = self._get_attribute(combined_status, 'sha')
148-
self.state = self._get_attribute(combined_status, 'state')
149-
statuses = self._get_attribute(combined_status, 'statuses', [])
147+
self.sha = combined_status['sha']
148+
self.state = combined_status['state']
149+
statuses = combined_status['statuses']
150150
self.statuses = [ShortStatus(s, self) for s in statuses]
151-
self.total_count = self._get_attribute(combined_status, 'total_count')
151+
self.total_count = combined_status['total_count']
152152

153153
def _repr(self):
154154
f = '<CombinedStatus [{s.state}:{s.total_count} sub-statuses]>'

0 commit comments

Comments
 (0)