-
-
Notifications
You must be signed in to change notification settings - Fork 848
Description
This commit has 3 comment(s) from core contributors that require attention.
Commit: d8322de9306b0972be795fa9f4a5ec0173d9c568
Comments:
-
Line 257: @stdlib-bot This return value is incorrect. Based on L111, this should be ~2.0817.
stdlib/lib/node_modules/@stdlib/stats/base/dnanstdevwd/README.md
Lines 254 to 260 in d8322de
const double x[] = { 1.0, -2.0, 0.0/0.0, 2.0 }; double v = stdlib_strided_dnanstdevwd( 4, 1.0, x, 1 ); // returns ~4.3333 ``` The function accepts the following arguments: -
Line 279: @stdlib-bot This return value is incorrect. Based on L111, this should be ~2.0817.
stdlib/lib/node_modules/@stdlib/stats/base/dnanstdevwd/README.md
Lines 276 to 282 in d8322de
const double x[] = { 1.0, -2.0, 0.0/0.0, 2.0 }; double v = stdlib_strided_dnanstdevwd_ndarray( 4, 1.0, x, 1, 0 ); // returns ~4.3333 ``` The function accepts the following arguments: -
Line 50: @stdlib-bot Should be
API_SUFFIX(stdlib_strided_dnanvariancewd_ndarray)
Interested in helping improve the project? If you are, the comment linked to above has 3 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.