Code refactor for AbsoluteMin improvements (TheAlgorithms#3022)

cristbjesus · web-flow · commit 02375e0683b7 · 2022-04-20T16:12:55.000+08:00
Fix TheAlgorithms#3021
diff --git a/src/main/java/com/thealgorithms/maths/AbsoluteMin.java b/src/main/java/com/thealgorithms/maths/AbsoluteMin.java
@@ -2,35 +2,31 @@
 
 import java.util.Arrays;
 
-/**
- * description:
- *
- * <p>
- * absMin([0, 5, 1, 11]) = 0, absMin([3 , -10, -2]) = -2
- */
 public class AbsoluteMin {
 
-    public static void main(String[] args) {
-        int[] testnums = {4, 0, 16};
-        assert absMin(testnums) == 0;
-
-        int[] numbers = {3, -10, -2};
-        System.out.println("absMin(" + Arrays.toString(numbers) + ") = " + absMin(numbers));
-    }
-
     /**
-     * get the value, returns the absolute min value min
+     * Compares the numbers given as arguments to get the absolute min value.
      *
-     * @param numbers contains elements
-     * @return the absolute min value
+     * @param numbers The numbers to compare
+     * @return The absolute min value
      */
-    public static int absMin(int[] numbers) {
-        int absMinValue = numbers[0];
-        for (int i = 1, length = numbers.length; i < length; ++i) {
-            if (Math.abs(numbers[i]) < Math.abs(absMinValue)) {
-                absMinValue = numbers[i];
-            }
+    public static int getMinValue(int... numbers) {
+        if (numbers.length == 0) {
+            throw new IllegalArgumentException("Numbers array cannot be empty");
         }
-        return absMinValue;
+
+        var absMinWrapper = new Object() {
+            int value = numbers[0];
+        };
+
+        Arrays.stream(numbers)
+                .skip(1)
+                .forEach(number -> {
+                    if (Math.abs(number) < Math.abs(absMinWrapper.value)) {
+                        absMinWrapper.value = number;
+                    }
+                });
+
+        return absMinWrapper.value;
     }
 }
diff --git a/src/test/java/com/thealgorithms/maths/AbsoluteMinTest.java b/src/test/java/com/thealgorithms/maths/AbsoluteMinTest.java
@@ -0,0 +1,21 @@
+package com.thealgorithms.maths;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+public class AbsoluteMinTest {
+
+    @Test
+    void testGetMinValue() {
+        assertEquals(0, AbsoluteMin.getMinValue(4, 0, 16));
+        assertEquals(-2, AbsoluteMin.getMinValue(3, -10, -2));
+    }
+
+    @Test
+    void testGetMinValueWithNoArguments() {
+        Exception exception = assertThrows(IllegalArgumentException.class, () -> AbsoluteMin.getMinValue());
+        assertEquals("Numbers array cannot be empty", exception.getMessage());
+    }
+}
