Skip to content

FPU inconsistencies #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
5 of 15 tasks
marcoieni opened this issue Mar 13, 2020 · 1 comment
Open
5 of 15 tasks

FPU inconsistencies #352

marcoieni opened this issue Mar 13, 2020 · 1 comment

Comments

@marcoieni
Copy link
Contributor

marcoieni commented Mar 13, 2020 •
edited
Loading

I searched for "FPU" on all svd. These are the inconsistencies I've found.
Let me know if you confirm these inconsistencies or not.

Since this is a long issue, we could do different pull requests to solve it. I would check the related entries once they are solved.

stm32l4x3

  • peripheral USB has FPU interrupt

stm32l4x2

  • peripheral VREFBUF has FPU interrupt

stm32l4s9, stm32l4s5, stm32l4r5, stm32l4s7, stm32l4r9, stm32l4r7 (new devices)

stm32l4x2

stm32l4x1, stm32f469, stm32f446, stm32f412, stm32f410, stm32f303

stm32h750x

  • peripheral PF has FPU interrupt

stm32f427, stm32f429, stm32f405, stm32f407

stm32f413

  • peripheral SDIO has FPU (and RCC) interrupts
  • peripheral ADC_Common has FPU interrupt
  • peripheral FPU has duplicated interrupts (fix fpu double interrupt #357)

stm32f411, stm32f401

Note

The problem "peripheral FPU has duplicated interrupt" has been solved in
stm32f3x4.yaml with the following code:

FPU:
  _delete:
    _interrupts:
      - FPU
  _add:
    _interrupts:
      FPU:
        description: Floating point unit
        value: 81
@adamgreig
Copy link
Member

Thanks for the detailed checking! A lot of interrupts are definitely in the wrong place; some have been fixed but since in general it doesn't cause any actual problems they haven't all been fixed. I'm very happy to take PRs fixing the interrupts though.

You might find the scripts/interrupts.py script useful if you've not already found it.

marcoieni added a commit to marcoieni/stm32-rs that referenced this issue Mar 15, 2020
@marcoieni
fix fpu double interrupt
74af924 
As detailed in issue stm32-rs#352, a lot of microcontrollers svd have a duplicated
FPU interrupt entry.

This problem has already been fixed for stm32f3x4.
This commit apply this fix to all the other microcontrollers that
need it.
@marcoieni marcoieni mentioned this issue Mar 15, 2020
Merged
marcoieni added a commit to marcoieni/stm32-rs that referenced this issue Mar 29, 2020
@marcoieni
fix fpu double interrupt for existing devices
9408b1c 
As detailed in issue stm32-rs#352, a lot of microcontrollers svd have a duplicated
FPU interrupt entry.

This problem has already been fixed for stm32f3x4.
This commit apply this fix to all the other existing microcontrollers that
need it.
bors bot added a commit that referenced this issue Mar 29, 2020
@bors @marcoieni
Merge #357
8caf527 
357: fix fpu double interrupt r=adamgreig a=MarcoIeni

As detailed in issue #352, a lot of microcontrollers svd have a duplicated FPU interrupt entry.

This problem has already been fixed for stm32f3x4.
This commit apply this fix to all the other microcontrollers that need it.

Co-authored-by: MarcoIeni <marcoieni94@gmail.com>
bors bot added a commit that referenced this issue Mar 29, 2020
@bors @richardeoin @marcoieni
Merge #353 #357 #359
0fd2bcd 
353: Add RAMECC registers across the H7 family r=adamgreig a=richardeoin

RAMECC was 'added' to the single core parts in RM0433 Rev 7. For the dual core parts there are definitions in the SVD, but they are so terrible it's worth starting over (there are registers with the wrong address, and the wrong fields)

For a use case, there is at least one set of commercial spaceflight hardware using the H7:
(no affiliation, no endorsement intended)

- [Nanoavionics OBC](https://nanoavionics.com/cubesat-components/cubesat-on-board-computer-main-bus-unit-satbus-3c2/)

357: fix fpu double interrupt r=adamgreig a=MarcoIeni

As detailed in issue #352, a lot of microcontrollers svd have a duplicated FPU interrupt entry.

This problem has already been fixed for stm32f3x4.
This commit apply this fix to all the other microcontrollers that need it.

359: H7, AXI: Add some basic definitions for AXI management r=adamgreig a=richardeoin



Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>
Co-authored-by: MarcoIeni <marcoieni94@gmail.com>
marcoieni added a commit to marcoieni/stm32-rs that referenced this issue Mar 29, 2020
@marcoieni
fix fpu double interrupt for new devices
61e68db 
As detailed in issue stm32-rs#352, a lot of microcontrollers svd have a duplicated
FPU interrupt entry.

This problem has already been fixed for all the existing microcontrollers.
This commit apply this fix to all the new microcontrollers that need it.
@marcoieni marcoieni mentioned this issue Mar 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamgreig @marcoieni