-
Notifications
You must be signed in to change notification settings - Fork 243
install prebuild binary on windows with cargo make install
#865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eZioPan
wants to merge
8
commits into
stm32-rs:master
Choose a base branch
from
eZioPan:cargo_make-for-windows
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please, squash and rebase commits |
db65239
to
abe6973
Compare
@burrbull I haven't do a rebase before, is this one ok? |
|
thanks, I have do a rebase that squash my original commits into 4 commits, would you check if it is ok? |
…rgo_make-for-windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and bump up
svd2html
version to0.1.4
, which add windows and macos prebuild binaryIn theory, it could be easy to support both macos and linux, but duckscript is lack of tools to unzip
.gz
, so there still need to usetool_install.sh
and manually install.Current state:
Replace PR #850
Pending on issue in this merged PR, will need to update the svd2rust versionWaiting PR #871 to be merged