Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not work #17

Open
chrisberry opened this issue Feb 23, 2021 · 1 comment
Open

Do not work #17

chrisberry opened this issue Feb 23, 2021 · 1 comment

Comments

@chrisberry
Copy link

I pulled repo and built it local. I added the extension per directions in the read me for Chrome. I went to Youtube and pick the first video found regarding cars. I click the Stream Together ICON located in the toolbar, copied the link.

I then went to my local instance of FireFox and added the extension per the read me file. I pasted the prev. link copied from Chrome and opened it in FireFox.

The videos are not in sync and the Chrome extension did indicate anyone had joined the watch part. It read zero people in attendance.
@hnryjms
Copy link
Member

hnryjms commented Mar 31, 2022

I've seen a few issues like this before and haven't fully narrowed it down. Usually I can refresh the page and the video can be discovered by the browser.

If I had to make a guess, this happens because the session.ts file only looks for a video when you click the extension button for the first time on that page. If it injects the code before the <video /> tag is ready (maybe the site uses an <img /> tag that gets swapped with a video tag), then it doesn't hook into anything, and just spins for a while.

It would be great if there was a "Retry" button in the extension when no video is detected. That way, if (above) is indeed the issue, then you could maybe fix it yourself without having to reload the page. @wmww added NoVideo events in #26 so maybe a Retry button there could solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisberry @hnryjms