Skip to content

Necessary changes to support PersistedModel.updateAll #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2015
Merged

Necessary changes to support PersistedModel.updateAll #68

merged 2 commits into from
Nov 4, 2015

Conversation

hideya
Copy link
Contributor

@hideya hideya commented Oct 23, 2015

There are cases where some of the parameters go to the query string whereas the others go to the message body after JSON encoding. One of such example is PersistedModel.updateAll:

https://github.com/strongloop/loopback/blob/32085475ed027f5a225e8023a69c98f1950cb7b9/lib/persisted-model.js#L635-L639

accepts: [
  {arg: 'where', type: 'object', http: {source: 'query'}, description: '...'},
  {arg: 'data', type: 'object', http: {source: 'body'}, description: '...'},
],

where has http.source: query, therefore it should be encoded into the query string.
data has http.source: body, therefore it should be encoded via AFJSONParameterEncoding and put into the request body.

However, the current SLRESTAdapter's invokeStaticMethod and invokeInstanceMethod implementations don't support such parameter handling -- the both process all the parameters with AFJSONParameterEncoding when the verb is PUT or POST.

This PR introduces jsonParameters argument that explicitly specifies the parameters that need to go to the request body.

@raymondfeng would you please review the changes?

@raymondfeng
Copy link
Contributor

Maybe call it as bodyParameters?

@hideya
Copy link
Contributor Author

hideya commented Oct 23, 2015

Maybe call it as bodyParameter?

That's sounds better! Thanks. I'll update the name quickly.

@hideya hideya force-pushed the fix/parameter-handling branch from caea182 to 2c14cdd Compare October 23, 2015 21:24
@hideya
Copy link
Contributor Author

hideya commented Oct 29, 2015

I've piggybacked rearrangement of LBPersistedModel's success block typedefs which is used for the codegen work.

@hideya hideya mentioned this pull request Oct 30, 2015
Merged
raymondfeng added a commit that referenced this pull request Nov 4, 2015
@raymondfeng
Merge pull request #68 from hideya/fix/parameter-handling
8d88207 
Necessary changes to support PersistedModel.updateAll
@raymondfeng raymondfeng merged commit 8d88207 into strongloop-community:master Nov 4, 2015
hideya added a commit to hideya/loopback-sdk-ios that referenced this pull request Nov 26, 2015
@hideya
Fix an error in [LBContainer createContainerWithName:success:failure:…
3765da6 
…] (a regression introduced by PR strongloop-community#68)
hideya added a commit to hideya/loopback-sdk-ios that referenced this pull request Dec 4, 2015
@hideya
Fix a regression introduced by PR strongloop-community#68
66b744c
hideya added a commit to hideya/loopback-sdk-ios that referenced this pull request Dec 5, 2015
@hideya
Fix a regression introduced by PR strongloop-community#68
a39ea87
raymondfeng pushed a commit that referenced this pull request Jan 19, 2016
1.3.1
3b116e6 
 * Remove docs and docs-1.0 leave md files and img (crandmck)
 * Fix swift compatibility issue when init'ing repo (hideya kawahara)
 * Added resetPasswordWithEmail to trigger reset of the users password (Kevin Gödecke)
 * Enable unit test execution from 'npm test' (hideya kawahara)
 * Fix a regression introduced by PR #68 (hideya kawahara)
 * Refine `+[LBPersistedModelRepository repository]` (hideya kawahara)
 * Update Subclassing.md (Aleksandar Kex Trpeski)
 * test-server: fix Container's base class to Model (Miroslav Bajtoš)
 * Add modulemap to the framework (hideya kawahara)
 * Clean up headers for unit tests (hideya kawahara)
 * Make private headers project private (hideya kawahara)
 * Add missing MobileCoreServices and SystemConfiguration to Podspec (hideya kawahara)
 * Rearrange LBPersistedModel's success block typedefs (hideya kawahara)
 * Necessary changes to support PersistedModel.updateAll (hideya kawahara)
 * Pass only necessary parameter in [LBPersistedModel destroyWithSuccess] (hideya kawahara)
 * Add LBPersistedModelTests's testFindWithFilter, testFindOne and testFindOneWithFilter to defaultTestSuite (hideya kawahara)
 * Use NSInteger instead of long (hideya kawahara)
 * Clean-up [<model-repository> repository] implementations. (hideya kawahara)
 * Add support for Date type (hideya kawahara)
 * Add findWithFilter/findOneWithFilter (Raymond Feng)
 * Allow Obj-C property mapping to use primitive types for Number type (hideya kawahara)
 * Minor refinements for LBPersistedModelTests.m and LBPersistedModelSubclassingTests.m (hideya kawahara)
 * Add file deletion to LBFile and streaming/binary data upload/download methods to LBFileRepository (hideya kawahara)
 * Import of MobileCoreServices in LBFile.m improved as mentioned in #46 (Lennart Stolz)
 * Fix Issue #51 -- add explicit @synthesize for _id (hideya kawahara)
 * add support for compilation of push notification registration on iOS SDK on Xcode 4 and older (hideya kawahara)
 * Intorduce LB 2.0 Persisted Model support (hideya kawahara)
 * Compile on MacOSX (Sylvain Ageneau)
 * Convert unit tests to XCTest (Sylvain Ageneau)
 * Fix build error with AFNetworking 1.x on macOS (Sylvain Ageneau)
 * Fix the URL generation code so that it won't attach bogus parameters. (hideya kawahara)
 * Update to strong-remoting 2.x (Raymond Feng)
 * Remove the deprecation warning (Raymond Feng)
 * Fix implementation issues found in LBFile and SLRESTAdapter. Add a feature to the adapter's invoke methods for handling response data via output stream. (hideya kawahara)
 * Remove warnings: - validate poject settings as xcode 6 recommends (use ONLY_ACTIVE_ARCH for debug   and change test productType to "com.apple.product-type.bundle.ocunit-test") - remove SLRemotingTests/server files from the build targets - add MobileCoreServices.h and SystemConfiguration.h to LoopBack-Prefix.pch   (and remove Foundation.h) - add MobileCoreServices and SystemConfiguration frameworks to the test targets - remove libobjc.A.dylib from the build targets - add an explicit "@synthesize connected" to SLRESTAdapter.m Minor improvements: - rearrange files in xcode project navigator - register LoopBackTests/server with xcode for easier reference - fix a typo in LBUserTests.m (hideya kawahara)
 * Update push notification registration method for iOS 8 (hideya kawahara)
 * Add findCurrentUser and cachedCurrentUser to LBUserRepository (hideya kawahara)
 * Implement UserRepository.currentUserId (hideya kawahara)
 * Fix contract mistakes in LBUser -- Fix Issue 26 - Fix the verb for login method (changed from GET to POST) - Add missing contract configuration for login ("login?include=user") - Improve [LBUserTest -testLogout] to test if the logout actually took effect - Update test server's package.json to use loopback 2.x instead of 1.x   (this unveiled the above verb mistake issue) (hideya kawahara)
 * Change prefix from "AF" to "SLAF" for two more methods to avoid build error with AFNetowrking 1.x (hideya kawahara)
 * Preserve REST access token across application restarts (hideya kawahara)
 * Add unit test for SLRESTAdapter's custom request header handling (hideya kawahara)
 * Fix a subclassing issue in LBModel (hideya kawahara)
 * Update README.md (Rand McKinney)
 * Add 'StrongLoop Labs' (Rand McKinney)
 * Fix bad CLA URL in CONTRIBUTING.md (Ryan Graham)
 * fix(pods):Removes SenTestingKit Framework From Podspec (Alex Bell)
 * Add contribution guidelines (Ryan Graham)
 * Fix the tests (Raymond Feng)
 * Create the SLRemotingTests target (Raymond Feng)
 * Make LBAccessToken.h public (Raymond Feng)
 * Add SLRemoting (Raymond Feng)
 * Remove SLRemoting submodule (Raymond Feng)
 * Update module name (Raymond Feng)
 * Make AFNetworking and SLRemoting headers public (Raymond Feng)
 * Bump version (Raymond Feng)
 * Update refs to SLRemoting (Raymond Feng)
 * Update strong remoting version (Raymond Feng)
 * Update to dual MIT/StrongLoop license (Raymond Feng)
 * LBFile cleanup and switch to streaming upload (Stephen Hess)
 * Unit testing for Container, User and File (Stephen Hess)
 * LBContainer (Stephen Hess)
 * LBFile WIP (Stephen Hess)
 * Add User & AccessToken models and enable ACLs. (Miroslav Bajtoš)
 * Use loopback-push-notification from npmjs.org (Miroslav Bajtoš)
 * Cleanup (Stephen Hess)
 * User updated with proper access token handling. (Stephen Hess)
 * User class (Stephen Hess)
raymondfeng pushed a commit that referenced this pull request Jan 19, 2016
1.3.1
dba2b25 
 * Remove docs and docs-1.0 leave md files and img (crandmck)
 * Fix swift compatibility issue when init'ing repo (hideya kawahara)
 * Added resetPasswordWithEmail to trigger reset of the users password (Kevin Gödecke)
 * Enable unit test execution from 'npm test' (hideya kawahara)
 * Fix a regression introduced by PR #68 (hideya kawahara)
 * Refine `+[LBPersistedModelRepository repository]` (hideya kawahara)
 * Update Subclassing.md (Aleksandar Kex Trpeski)
 * test-server: fix Container's base class to Model (Miroslav Bajtoš)
 * Add modulemap to the framework (hideya kawahara)
 * Clean up headers for unit tests (hideya kawahara)
 * Make private headers project private (hideya kawahara)
 * Add missing MobileCoreServices and SystemConfiguration to Podspec (hideya kawahara)
 * Rearrange LBPersistedModel's success block typedefs (hideya kawahara)
 * Necessary changes to support PersistedModel.updateAll (hideya kawahara)
 * Pass only necessary parameter in [LBPersistedModel destroyWithSuccess] (hideya kawahara)
 * Add LBPersistedModelTests's testFindWithFilter, testFindOne and testFindOneWithFilter to defaultTestSuite (hideya kawahara)
 * Use NSInteger instead of long (hideya kawahara)
 * Clean-up [<model-repository> repository] implementations. (hideya kawahara)
 * Add support for Date type (hideya kawahara)
 * Add findWithFilter/findOneWithFilter (Raymond Feng)
 * Allow Obj-C property mapping to use primitive types for Number type (hideya kawahara)
 * Minor refinements for LBPersistedModelTests.m and LBPersistedModelSubclassingTests.m (hideya kawahara)
 * Add file deletion to LBFile and streaming/binary data upload/download methods to LBFileRepository (hideya kawahara)
 * Import of MobileCoreServices in LBFile.m improved as mentioned in #46 (Lennart Stolz)
 * Fix Issue #51 -- add explicit @synthesize for _id (hideya kawahara)
 * add support for compilation of push notification registration on iOS SDK on Xcode 4 and older (hideya kawahara)
 * Intorduce LB 2.0 Persisted Model support (hideya kawahara)
 * Compile on MacOSX (Sylvain Ageneau)
 * Convert unit tests to XCTest (Sylvain Ageneau)
 * Fix build error with AFNetworking 1.x on macOS (Sylvain Ageneau)
 * Fix the URL generation code so that it won't attach bogus parameters. (hideya kawahara)
 * Update to strong-remoting 2.x (Raymond Feng)
 * Remove the deprecation warning (Raymond Feng)
 * Fix implementation issues found in LBFile and SLRESTAdapter. Add a feature to the adapter's invoke methods for handling response data via output stream. (hideya kawahara)
 * Remove warnings: - validate poject settings as xcode 6 recommends (use ONLY_ACTIVE_ARCH for debug   and change test productType to "com.apple.product-type.bundle.ocunit-test") - remove SLRemotingTests/server files from the build targets - add MobileCoreServices.h and SystemConfiguration.h to LoopBack-Prefix.pch   (and remove Foundation.h) - add MobileCoreServices and SystemConfiguration frameworks to the test targets - remove libobjc.A.dylib from the build targets - add an explicit "@synthesize connected" to SLRESTAdapter.m Minor improvements: - rearrange files in xcode project navigator - register LoopBackTests/server with xcode for easier reference - fix a typo in LBUserTests.m (hideya kawahara)
 * Update push notification registration method for iOS 8 (hideya kawahara)
 * Add findCurrentUser and cachedCurrentUser to LBUserRepository (hideya kawahara)
 * Implement UserRepository.currentUserId (hideya kawahara)
 * Fix contract mistakes in LBUser -- Fix Issue 26 - Fix the verb for login method (changed from GET to POST) - Add missing contract configuration for login ("login?include=user") - Improve [LBUserTest -testLogout] to test if the logout actually took effect - Update test server's package.json to use loopback 2.x instead of 1.x   (this unveiled the above verb mistake issue) (hideya kawahara)
 * Change prefix from "AF" to "SLAF" for two more methods to avoid build error with AFNetowrking 1.x (hideya kawahara)
 * Preserve REST access token across application restarts (hideya kawahara)
 * Add unit test for SLRESTAdapter's custom request header handling (hideya kawahara)
 * Fix a subclassing issue in LBModel (hideya kawahara)
 * Update README.md (Rand McKinney)
 * Add 'StrongLoop Labs' (Rand McKinney)
 * Fix bad CLA URL in CONTRIBUTING.md (Ryan Graham)
 * fix(pods):Removes SenTestingKit Framework From Podspec (Alex Bell)
 * Add contribution guidelines (Ryan Graham)
 * Fix the tests (Raymond Feng)
 * Create the SLRemotingTests target (Raymond Feng)
 * Make LBAccessToken.h public (Raymond Feng)
 * Add SLRemoting (Raymond Feng)
 * Remove SLRemoting submodule (Raymond Feng)
 * Update module name (Raymond Feng)
 * Make AFNetworking and SLRemoting headers public (Raymond Feng)
 * Bump version (Raymond Feng)
 * Update refs to SLRemoting (Raymond Feng)
 * Update strong remoting version (Raymond Feng)
 * Update to dual MIT/StrongLoop license (Raymond Feng)
 * LBFile cleanup and switch to streaming upload (Stephen Hess)
 * Unit testing for Container, User and File (Stephen Hess)
 * LBContainer (Stephen Hess)
 * LBFile WIP (Stephen Hess)
 * Add User & AccessToken models and enable ACLs. (Miroslav Bajtoš)
 * Use loopback-push-notification from npmjs.org (Miroslav Bajtoš)
 * Cleanup (Stephen Hess)
 * User updated with proper access token handling. (Stephen Hess)
 * User class (Stephen Hess)
raymondfeng pushed a commit that referenced this pull request Jan 19, 2016
1.3.2
fee8055 
 * Remove docs and docs-1.0 leave md files and img (crandmck)
 * Fix swift compatibility issue when init'ing repo (hideya kawahara)
 * Added resetPasswordWithEmail to trigger reset of the users password (Kevin Gödecke)
 * Enable unit test execution from 'npm test' (hideya kawahara)
 * Fix a regression introduced by PR #68 (hideya kawahara)
 * Refine `+[LBPersistedModelRepository repository]` (hideya kawahara)
 * Update Subclassing.md (Aleksandar Kex Trpeski)
 * test-server: fix Container's base class to Model (Miroslav Bajtoš)
 * Add modulemap to the framework (hideya kawahara)
 * Clean up headers for unit tests (hideya kawahara)
 * Make private headers project private (hideya kawahara)
 * Add missing MobileCoreServices and SystemConfiguration to Podspec (hideya kawahara)
 * Rearrange LBPersistedModel's success block typedefs (hideya kawahara)
 * Necessary changes to support PersistedModel.updateAll (hideya kawahara)
 * Pass only necessary parameter in [LBPersistedModel destroyWithSuccess] (hideya kawahara)
 * Add LBPersistedModelTests's testFindWithFilter, testFindOne and testFindOneWithFilter to defaultTestSuite (hideya kawahara)
 * Use NSInteger instead of long (hideya kawahara)
 * Clean-up [<model-repository> repository] implementations. (hideya kawahara)
 * Add support for Date type (hideya kawahara)
 * Add findWithFilter/findOneWithFilter (Raymond Feng)
 * Allow Obj-C property mapping to use primitive types for Number type (hideya kawahara)
 * Minor refinements for LBPersistedModelTests.m and LBPersistedModelSubclassingTests.m (hideya kawahara)
 * Add file deletion to LBFile and streaming/binary data upload/download methods to LBFileRepository (hideya kawahara)
 * Import of MobileCoreServices in LBFile.m improved as mentioned in #46 (Lennart Stolz)
 * Fix Issue #51 -- add explicit @synthesize for _id (hideya kawahara)
 * add support for compilation of push notification registration on iOS SDK on Xcode 4 and older (hideya kawahara)
 * Intorduce LB 2.0 Persisted Model support (hideya kawahara)
 * Compile on MacOSX (Sylvain Ageneau)
 * Convert unit tests to XCTest (Sylvain Ageneau)
 * Fix build error with AFNetworking 1.x on macOS (Sylvain Ageneau)
 * Fix the URL generation code so that it won't attach bogus parameters. (hideya kawahara)
 * Update to strong-remoting 2.x (Raymond Feng)
 * Remove the deprecation warning (Raymond Feng)
 * Fix implementation issues found in LBFile and SLRESTAdapter. Add a feature to the adapter's invoke methods for handling response data via output stream. (hideya kawahara)
 * Remove warnings: - validate poject settings as xcode 6 recommends (use ONLY_ACTIVE_ARCH for debug   and change test productType to "com.apple.product-type.bundle.ocunit-test") - remove SLRemotingTests/server files from the build targets - add MobileCoreServices.h and SystemConfiguration.h to LoopBack-Prefix.pch   (and remove Foundation.h) - add MobileCoreServices and SystemConfiguration frameworks to the test targets - remove libobjc.A.dylib from the build targets - add an explicit "@synthesize connected" to SLRESTAdapter.m Minor improvements: - rearrange files in xcode project navigator - register LoopBackTests/server with xcode for easier reference - fix a typo in LBUserTests.m (hideya kawahara)
 * Update push notification registration method for iOS 8 (hideya kawahara)
 * Add findCurrentUser and cachedCurrentUser to LBUserRepository (hideya kawahara)
 * Implement UserRepository.currentUserId (hideya kawahara)
 * Fix contract mistakes in LBUser -- Fix Issue 26 - Fix the verb for login method (changed from GET to POST) - Add missing contract configuration for login ("login?include=user") - Improve [LBUserTest -testLogout] to test if the logout actually took effect - Update test server's package.json to use loopback 2.x instead of 1.x   (this unveiled the above verb mistake issue) (hideya kawahara)
 * Change prefix from "AF" to "SLAF" for two more methods to avoid build error with AFNetowrking 1.x (hideya kawahara)
 * Preserve REST access token across application restarts (hideya kawahara)
 * Add unit test for SLRESTAdapter's custom request header handling (hideya kawahara)
 * Fix a subclassing issue in LBModel (hideya kawahara)
 * Update README.md (Rand McKinney)
 * Add 'StrongLoop Labs' (Rand McKinney)
 * Fix bad CLA URL in CONTRIBUTING.md (Ryan Graham)
 * fix(pods):Removes SenTestingKit Framework From Podspec (Alex Bell)
 * Add contribution guidelines (Ryan Graham)
 * Fix the tests (Raymond Feng)
 * Create the SLRemotingTests target (Raymond Feng)
 * Make LBAccessToken.h public (Raymond Feng)
 * Add SLRemoting (Raymond Feng)
 * Remove SLRemoting submodule (Raymond Feng)
 * Update module name (Raymond Feng)
 * Make AFNetworking and SLRemoting headers public (Raymond Feng)
 * Bump version (Raymond Feng)
 * Update refs to SLRemoting (Raymond Feng)
 * Update strong remoting version (Raymond Feng)
 * Update to dual MIT/StrongLoop license (Raymond Feng)
 * LBFile cleanup and switch to streaming upload (Stephen Hess)
 * Unit testing for Container, User and File (Stephen Hess)
 * LBContainer (Stephen Hess)
 * LBFile WIP (Stephen Hess)
 * Add User & AccessToken models and enable ACLs. (Miroslav Bajtoš)
 * Use loopback-push-notification from npmjs.org (Miroslav Bajtoš)
 * Cleanup (Stephen Hess)
 * User updated with proper access token handling. (Stephen Hess)
 * User class (Stephen Hess)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raymondfeng raymondfeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hideya @raymondfeng @altsang