Skip to content

Commit b3d34ac

Browse files
bnoordhuisBimal Kumar Jha
authored and
Bimal Kumar Jha
committed
Delete dead dynodbc code. (ibmdb#225)
The code in src/dynodbc.cpp is not compiled because it's wrapped in a big #ifdef statement. Dead code is bad code, delete it.
1 parent f229e0c commit b3d34ac

File tree

6 files changed

+0
-617
lines changed

6 files changed

+0
-617
lines changed

binding.gyp

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
'src/odbc_connection.cpp',
88
'src/odbc_statement.cpp',
99
'src/odbc_result.cpp',
10-
'src/dynodbc.cpp'
1110
],
1211
'include_dirs': [
1312
"<!(node -e \"require('nan')\")"

lib/odbc.js

-16
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ module.exports.ODBC = odbc.ODBC;
4646
module.exports.ODBCConnection = odbc.ODBCConnection;
4747
module.exports.ODBCStatement = odbc.ODBCStatement;
4848
module.exports.ODBCResult = odbc.ODBCResult;
49-
module.exports.loadODBCLibrary = odbc.loadODBCLibrary;
5049

5150
exports.debug = false;
5251
var ibmdbStartTime = new Date();
@@ -136,21 +135,6 @@ function Database(options)
136135

137136
options = options || {};
138137

139-
if (odbc.loadODBCLibrary)
140-
{
141-
if (!options.library && !module.exports.library)
142-
{
143-
throw new Error("You must specify a library when complied with dynodbc, "
144-
+ "otherwise this jams will segfault.");
145-
}
146-
147-
if (!odbc.loadODBCLibrary(options.library || module.exports.library))
148-
{
149-
throw new Error("Could not load library. You may need to specify full "
150-
+ "path.");
151-
}
152-
}
153-
154138
self.odbc = (options.odbc) ? options.odbc : ((ENV) ? ENV : new odbc.ODBC());
155139
if(!ENV) ENV = self.odbc;
156140
self.queue = new SimpleQueue();

src/dynodbc.cpp

-189
This file was deleted.

0 commit comments

Comments
 (0)