Fix MySQL install failing on UmbracoServer table

nul800sebastiaan · nul800sebastiaan · commit 2111a5e31e90 · 2013-09-01T17:28:22.000+02:00
diff --git a/src/Umbraco.Core/Persistence/DatabaseModelDefinitions/DefinitionFactory.cs b/src/Umbraco.Core/Persistence/DatabaseModelDefinitions/DefinitionFactory.cs
@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Reflection;
 using Umbraco.Core.Persistence.DatabaseAnnotations;
+using Umbraco.Core.Persistence.SqlSyntax;
 
 namespace Umbraco.Core.Persistence.DatabaseModelDefinitions
 {
@@ -107,6 +108,12 @@ public static ColumnDefinition GetColumnDefinition(Type modelType, PropertyInfo
             var constraintAttribute = propertyInfo.FirstAttribute<ConstraintAttribute>();
             if (constraintAttribute != null)
             {
+                //Special case for MySQL as it can't have multiple default DateTime values, which 
+                //is what the umbracoServer table definition is trying to create
+                if (SqlSyntaxContext.SqlSyntaxProvider is MySqlSyntaxProvider && definition.TableName == "umbracoServer" &&
+                        definition.TableName.ToLowerInvariant() == "lastNotifiedDate".ToLowerInvariant())
+                    return definition;
+
                 definition.ConstraintName = constraintAttribute.Name ?? string.Empty;
                 definition.DefaultValue = constraintAttribute.Default ?? string.Empty;
             }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`using System.Linq;`
`4`	`4`	`using System.Reflection;`
`5`	`5`	`using Umbraco.Core.Persistence.DatabaseAnnotations;`
	`6`	`+using Umbraco.Core.Persistence.SqlSyntax;`
`6`	`7`
`7`	`8`	`namespace Umbraco.Core.Persistence.DatabaseModelDefinitions`
`8`	`9`	`{`
`@@ -107,6 +108,12 @@ public static ColumnDefinition GetColumnDefinition(Type modelType, PropertyInfo`
`107`	`108`	`var constraintAttribute = propertyInfo.FirstAttribute<ConstraintAttribute>();`
`108`	`109`	`if (constraintAttribute != null)`
`109`	`110`	`{`
	`111`	`+ //Special case for MySQL as it can't have multiple default DateTime values, which`
	`112`	`+ //is what the umbracoServer table definition is trying to create`
	`113`	`+ if (SqlSyntaxContext.SqlSyntaxProvider is MySqlSyntaxProvider && definition.TableName == "umbracoServer" &&`
	`114`	`+ definition.TableName.ToLowerInvariant() == "lastNotifiedDate".ToLowerInvariant())`
	`115`	`+ return definition;`
	`116`	`+`
`110`	`117`	`definition.ConstraintName = constraintAttribute.Name ?? string.Empty;`
`111`	`118`	`definition.DefaultValue = constraintAttribute.Default ?? string.Empty;`
`112`	`119`	`}`