publicizes the legacy parameter editor alias map, ensures that a YSOD is not shown when a legacy parameter editor is trying to be rendered, we just render a text box in its place

Shazwazza · Shazwazza · commit 22be517daf01 · 2013-11-21T18:10:47.000+11:00
diff --git a/src/Umbraco.Core/PropertyEditors/LegacyParameterEditorAliasConverter.cs b/src/Umbraco.Core/PropertyEditors/LegacyParameterEditorAliasConverter.cs
@@ -10,7 +10,7 @@ namespace Umbraco.Core.PropertyEditors
     /// Used to map the legacy parameter editor aliases to the new ones, this is really just used during 
     /// installation but has been put in a separate class in case we need it for other purposes
     /// </summary>
-    internal static class LegacyParameterEditorAliasConverter
+    public static class LegacyParameterEditorAliasConverter
     {
         /// <summary>
         /// The map consists of a key which is always the legacy alias + new alias (trimmed))
diff --git a/src/Umbraco.Web/Models/Mapping/MacroModelMapper.cs b/src/Umbraco.Web/Models/Mapping/MacroModelMapper.cs
@@ -3,6 +3,7 @@
 using System.Linq;
 using AutoMapper;
 using Umbraco.Core;
+using Umbraco.Core.Logging;
 using Umbraco.Core.Models;
 using Umbraco.Core.Models.Mapping;
 using Umbraco.Core.PropertyEditors;
@@ -34,12 +35,15 @@ public override void ConfigureMappings(IConfiguration config, ApplicationContext
                           var paramEditor = ParameterEditorResolver.Current.GetByAlias(property.EditorAlias);
                           if (paramEditor == null)
                           {
-                              throw new InvalidOperationException("Could not resolve macro parameter editor: " + property.EditorAlias);
+                              //we'll just map this to a text box
+                              paramEditor = ParameterEditorResolver.Current.GetByAlias(Constants.PropertyEditors.TextboxAlias);
+                              LogHelper.Warn<MacroModelMapper>("Could not resolve a parameter editor with alias " + property.EditorAlias + ", a textbox will be rendered in it's place");
                           }
-                          parameter.View = paramEditor.ValueEditor.View;
 
+                          parameter.View = paramEditor.ValueEditor.View;
                           //set the config
                           parameter.Configuration = paramEditor.Configuration;
+                          
                       });
 
         }

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace Umbraco.Core.PropertyEditors`
`10`	`10`	`/// Used to map the legacy parameter editor aliases to the new ones, this is really just used during`
`11`	`11`	`/// installation but has been put in a separate class in case we need it for other purposes`
`12`	`12`	`/// </summary>`
`13`		`- internal static class LegacyParameterEditorAliasConverter`
	`13`	`+ public static class LegacyParameterEditorAliasConverter`
`14`	`14`	`{`
`15`	`15`	`/// <summary>`
`16`	`16`	`/// The map consists of a key which is always the legacy alias + new alias (trimmed))`