Adds a simple cache mechanism to hold reflected property info when cloning - reduces perf to 10% of what it used to be

Shazwazza · Shazwazza · commit 774f2015144e · 2014-08-20T20:09:05.000-06:00
diff --git a/src/Umbraco.Core/Models/DeepCloneHelper.cs b/src/Umbraco.Core/Models/DeepCloneHelper.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
@@ -27,6 +28,11 @@ internal class DoNotCloneAttribute : Attribute
 
     public static class DeepCloneHelper
     {
+        /// <summary>
+        /// Used to avoid constant reflection (perf)
+        /// </summary>
+        private static readonly ConcurrentDictionary<Type, PropertyInfo[]> PropCache = new ConcurrentDictionary<Type, PropertyInfo[]>(); 
+
         /// <summary>
         /// Used to deep clone any reference properties on the object (should be done after a MemberwiseClone for which the outcome is 'output')
         /// </summary>
@@ -43,16 +49,18 @@ public static void DeepCloneRefProperties(IDeepCloneable input, IDeepCloneable o
                 throw new InvalidOperationException("Both the input and output types must be the same");
             }
 
-            var refProperties = inputType.GetProperties()
-                .Where(x =>
-                    //is not attributed with the ignore clone attribute
+            var refProperties = PropCache.GetOrAdd(inputType, type =>
+                inputType.GetProperties()
+                    .Where(x =>
+                        //is not attributed with the ignore clone attribute
                     Attribute.GetCustomAttribute(x, typeof(DoNotCloneAttribute)) == null
-                    //reference type but not string
-                    && x.PropertyType.IsValueType == false && x.PropertyType != typeof (string)
-                        //settable
-                    && x.CanWrite
-                        //non-indexed
-                    && x.GetIndexParameters().Any() == false);
+                            //reference type but not string
+                        && x.PropertyType.IsValueType == false && x.PropertyType != typeof (string)
+                            //settable
+                        && x.CanWrite
+                            //non-indexed
+                        && x.GetIndexParameters().Any() == false)
+                    .ToArray());
 
             foreach (var propertyInfo in refProperties)
             {
