U4-4650 Pluralization of document type aliases doesn't always work

nul800sebastiaan · nul800sebastiaan · commit a55cd67fd63d · 2014-05-16T14:33:25.000+02:00
diff --git a/src/Umbraco.Core/StringExtensions.cs b/src/Umbraco.Core/StringExtensions.cs
@@ -135,7 +135,7 @@ public static string DecryptWithMachineKey(this string value)
         //this is from SqlMetal and just makes it a bit of fun to allow pluralisation
         public static string MakePluralName(this string name)
         {
-            if ((name.EndsWith("x", StringComparison.OrdinalIgnoreCase) || name.EndsWith("ch", StringComparison.OrdinalIgnoreCase)) || (name.EndsWith("ss", StringComparison.OrdinalIgnoreCase) || name.EndsWith("sh", StringComparison.OrdinalIgnoreCase)))
+            if ((name.EndsWith("x", StringComparison.OrdinalIgnoreCase) || name.EndsWith("ch", StringComparison.OrdinalIgnoreCase)) || (name.EndsWith("s", StringComparison.OrdinalIgnoreCase) || name.EndsWith("sh", StringComparison.OrdinalIgnoreCase)))
             {
                 name = name + "es";
                 return name;

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public static string DecryptWithMachineKey(this string value)`
`135`	`135`	`//this is from SqlMetal and just makes it a bit of fun to allow pluralisation`
`136`	`136`	`public static string MakePluralName(this string name)`
`137`	`137`	`{`
`138`		`- if ((name.EndsWith("x", StringComparison.OrdinalIgnoreCase) \|\| name.EndsWith("ch", StringComparison.OrdinalIgnoreCase)) \|\| (name.EndsWith("ss", StringComparison.OrdinalIgnoreCase) \|\| name.EndsWith("sh", StringComparison.OrdinalIgnoreCase)))`
	`138`	`+ if ((name.EndsWith("x", StringComparison.OrdinalIgnoreCase) \|\| name.EndsWith("ch", StringComparison.OrdinalIgnoreCase)) \|\| (name.EndsWith("s", StringComparison.OrdinalIgnoreCase) \|\| name.EndsWith("sh", StringComparison.OrdinalIgnoreCase)))`
`139`	`139`	`{`
`140`	`140`	`name = name + "es";`
`141`	`141`	`return name;`