Fixes: U4-5801 macro container property needs to be type TEXT

Shazwazza · Shazwazza · commit ccd438ba261a · 2014-11-13T18:06:58.000+11:00
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.controller.js
@@ -66,20 +66,23 @@ angular.module('umbraco')
 				openDialog(index);
 		};
 
-		$scope.add =function(){
-				openDialog();
+		$scope.add = function () {
+
+		    if ($scope.model.config.max && $scope.model.config.max > 0 && $scope.renderModel.length >= $scope.model.config.max) {
+                //cannot add more than the max
+		        return;
+		    }
+		    
+			openDialog();
 		};
 
 		$scope.remove =function(index){
 			$scope.renderModel.splice(index, 1);
-			$scope.macros.splice(index, 1);
-			$scope.model.value = trim($scope.macros.join(), ",");
 		};
 
 	    $scope.clear = function() {
 	        $scope.model.value = "";
 	        $scope.renderModel = [];
-	        $scope.macros = [];
 	    };
 
 	    $scope.$on("formSubmitting", function (ev, args) {	
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.html
@@ -17,12 +17,12 @@
         </li>
 	</ul>
 
-	<ul class="unstyled list-icons">	
-		<li>
+    <ul class="unstyled list-icons" ng-hide="model.config.max && model.config.max > 0 && renderModel.length >= model.config.max">
+        <li>
             <i class="icon icon-add blue"></i>
-			<a href="#" ng-click="add()" prevent-default>
-				 <localize key="general_add">Add</localize>
-			</a>
-		</li>
-	</ul>
+            <a href="#" ng-click="add()" prevent-default>
+                <localize key="general_add">Add</localize>
+            </a>
+        </li>
+    </ul>
 </div>
diff --git a/src/Umbraco.Web/PropertyEditors/MacroContainerPropertyEditor.cs b/src/Umbraco.Web/PropertyEditors/MacroContainerPropertyEditor.cs
@@ -9,7 +9,7 @@
 
 namespace Umbraco.Web.PropertyEditors
 {
-    [PropertyEditor(Constants.PropertyEditors.MacroContainerAlias, "Macro container", "macrocontainer")]
+    [PropertyEditor(Constants.PropertyEditors.MacroContainerAlias, "Macro container", "macrocontainer", ValueType = "TEXT")]
     public class MacroContainerPropertyEditor : PropertyEditor
     {
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`
`10`	`10`	`namespace Umbraco.Web.PropertyEditors`
`11`	`11`	`{`
`12`		`- [PropertyEditor(Constants.PropertyEditors.MacroContainerAlias, "Macro container", "macrocontainer")]`
	`12`	`+ [PropertyEditor(Constants.PropertyEditors.MacroContainerAlias, "Macro container", "macrocontainer", ValueType = "TEXT")]`
`13`	`13`	`public class MacroContainerPropertyEditor : PropertyEditor`
`14`	`14`	`{`
`15`	`15`	`/// <summary>`