Fixes U4-2734 Don't set the cache references to null when disposing the UmbracoContext

Shazwazza · nul800sebastiaan · commit d22dbb4654ed · 2013-08-31T11:11:25.000+02:00
diff --git a/src/Umbraco.Web/UmbracoContext.cs b/src/Umbraco.Web/UmbracoContext.cs
@@ -370,8 +370,14 @@ protected override void DisposeResources()
             _umbracoContext = null;
             //ensure not to dispose this!
             Application = null;
-            ContentCache = null;
-            MediaCache = null;     
+
+            //Before we set these to null but in fact these are application lifespan singletons so 
+            //there's no reason we need to set them to null and this also caused a problem with packages
+            //trying to access the cache properties on RequestEnd.
+            //http://issues.umbraco.org/issue/U4-2734
+            //http://our.umbraco.org/projects/developer-tools/301-url-tracker/version-2/44327-Issues-with-URL-Tracker-in-614
+            //ContentCache = null;
+            //MediaCache = null;     
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -370,8 +370,14 @@ protected override void DisposeResources()`
`370`	`370`	`_umbracoContext = null;`
`371`	`371`	`//ensure not to dispose this!`
`372`	`372`	`Application = null;`
`373`		`- ContentCache = null;`
`374`		`- MediaCache = null;`
	`373`	`+`
	`374`	`+ //Before we set these to null but in fact these are application lifespan singletons so`
	`375`	`+ //there's no reason we need to set them to null and this also caused a problem with packages`
	`376`	`+ //trying to access the cache properties on RequestEnd.`
	`377`	`+ //http://issues.umbraco.org/issue/U4-2734`
	`378`	`+ //http://our.umbraco.org/projects/developer-tools/301-url-tracker/version-2/44327-Issues-with-URL-Tracker-in-614`
	`379`	`+ //ContentCache = null;`
	`380`	`+ //MediaCache = null;`
`375`	`381`	`}`
`376`	`382`	`}`
`377`	`383`	`}`