Merge pull request scala-js#3652 from exoego/resource-leak

gzm0 · web-flow · commit e4ec107b5b91 · 2019-06-06T11:32:38.000+02:00
Fix potential resource leak
diff --git a/partest/src/main-partest-1.0.16/scala/tools/partest/scalajs/ScalaJSPartest.scala b/partest/src/main-partest-1.0.16/scala/tools/partest/scalajs/ScalaJSPartest.scala
@@ -47,7 +47,12 @@ class ScalaJSRunner(testFile: File, suiteRunner: SuiteRunner,
         new nest.NestUI(diffOnFail = options.showDiff, colorEnabled = true)) {
   private val compliantSems: List[String] = {
     scalaJSConfigFile("sem").fold(List.empty[String]) { file =>
-      Source.fromFile(file).getLines.toList
+      val source = Source.fromFile(file)
+      try {
+        source.getLines.toList
+      } finally {
+        source.close()
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,12 @@ class ScalaJSRunner(testFile: File, suiteRunner: SuiteRunner,`
`47`	`47`	`new nest.NestUI(diffOnFail = options.showDiff, colorEnabled = true)) {`
`48`	`48`	`private val compliantSems: List[String] = {`
`49`	`49`	`scalaJSConfigFile("sem").fold(List.empty[String]) { file =>`
`50`		`- Source.fromFile(file).getLines.toList`
	`50`	`+ val source = Source.fromFile(file)`
	`51`	`+ try {`
	`52`	`+ source.getLines.toList`
	`53`	`+ } finally {`
	`54`	`+ source.close()`
	`55`	`+ }`
`51`	`56`	`}`
`52`	`57`	`}`
`53`	`58`