Support Jetty HandlerCollection types

liujiong1982 · philwebb · commit 64447d3f5fda · 2014-10-08T20:07:35.000-07:00
Update JettyEmbeddedServletContainer to support HandlerCollection types in addition to HandlerWrappers. Fixes spring-projectsgh-545 Closes spring-projectsgh-1597
diff --git a/spring-boot/src/main/java/org/springframework/boot/context/embedded/jetty/JettyEmbeddedServletContainer.java b/spring-boot/src/main/java/org/springframework/boot/context/embedded/jetty/JettyEmbeddedServletContainer.java
@@ -21,6 +21,7 @@
 import org.eclipse.jetty.server.Connector;
 import org.eclipse.jetty.server.Handler;
 import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.handler.HandlerCollection;
 import org.eclipse.jetty.server.handler.HandlerWrapper;
 import org.springframework.boot.context.embedded.EmbeddedServletContainer;
 import org.springframework.boot.context.embedded.EmbeddedServletContainerException;
@@ -34,6 +35,7 @@
  *
  * @author Phillip Webb
  * @author Dave Syer
+ * @author David Liu
  * @see JettyEmbeddedServletContainerFactory
  */
 public class JettyEmbeddedServletContainer implements EmbeddedServletContainer {
@@ -115,12 +117,17 @@ public void start() throws EmbeddedServletContainerException {
 		}
 	}
 
-	private void handleDeferredInitialize(Handler handler) throws Exception {
-		if (handler instanceof JettyEmbeddedWebAppContext) {
-			((JettyEmbeddedWebAppContext) handler).deferredInitialize();
-		}
-		else if (handler instanceof HandlerWrapper) {
-			handleDeferredInitialize(((HandlerWrapper) handler).getHandler());
+	private void handleDeferredInitialize(Handler... handlers) throws Exception {
+		for (Handler handler : handlers) {
+			if (handler instanceof JettyEmbeddedWebAppContext) {
+				((JettyEmbeddedWebAppContext) handler).deferredInitialize();
+			}
+			else if (handler instanceof HandlerWrapper) {
+				handleDeferredInitialize(((HandlerWrapper) handler).getHandler());
+			}
+			else if (handler instanceof HandlerCollection) {
+				handleDeferredInitialize(((HandlerCollection) handler).getHandlers());
+			}
 		}
 	}
 
diff --git a/spring-boot/src/test/java/org/springframework/boot/context/embedded/AbstractEmbeddedServletContainerFactoryTests.java b/spring-boot/src/test/java/org/springframework/boot/context/embedded/AbstractEmbeddedServletContainerFactoryTests.java
@@ -580,7 +580,7 @@ protected ClientHttpResponse getClientResponse(String url,
 
 	protected abstract AbstractEmbeddedServletContainerFactory getFactory();
 
-	private ServletContextInitializer exampleServletRegistration() {
+	protected ServletContextInitializer exampleServletRegistration() {
 		return new ServletRegistrationBean(new ExampleServlet(), "/hello");
 	}
 
diff --git a/spring-boot/src/test/java/org/springframework/boot/context/embedded/jetty/JettyEmbeddedServletContainerFactoryTests.java b/spring-boot/src/test/java/org/springframework/boot/context/embedded/jetty/JettyEmbeddedServletContainerFactoryTests.java
@@ -21,6 +21,8 @@
 
 import org.eclipse.jetty.server.Handler;
 import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.handler.HandlerCollection;
+import org.eclipse.jetty.server.handler.HandlerWrapper;
 import org.eclipse.jetty.server.ssl.SslConnector;
 import org.eclipse.jetty.webapp.Configuration;
 import org.eclipse.jetty.webapp.WebAppContext;
@@ -129,4 +131,24 @@ private void assertTimeout(JettyEmbeddedServletContainerFactory factory, int exp
 		assertThat(actual, equalTo(expected));
 	}
 
+	@Test
+	public void wrappedHandlers() throws Exception {
+		JettyEmbeddedServletContainerFactory factory = getFactory();
+		factory.setServerCustomizers(Arrays.asList(new JettyServerCustomizer() {
+			@Override
+			public void customize(Server server) {
+				Handler handler = server.getHandler();
+				HandlerWrapper wrapper = new HandlerWrapper();
+				wrapper.setHandler(handler);
+				HandlerCollection collection = new HandlerCollection();
+				collection.addHandler(wrapper);
+				server.setHandler(collection);
+			}
+		}));
+		this.container = factory
+				.getEmbeddedServletContainer(exampleServletRegistration());
+		this.container.start();
+		assertThat(getResponse(getLocalUrl("/hello")), equalTo("Hello World"));
+	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -580,7 +580,7 @@ protected ClientHttpResponse getClientResponse(String url,`
`580`	`580`
`581`	`581`	`protected abstract AbstractEmbeddedServletContainerFactory getFactory();`
`582`	`582`
`583`		`- private ServletContextInitializer exampleServletRegistration() {`
	`583`	`+ protected ServletContextInitializer exampleServletRegistration() {`
`584`	`584`	`return new ServletRegistrationBean(new ExampleServlet(), "/hello");`
`585`	`585`	`}`
`586`	`586`