fix: avoid Next.js Edge Runtime warnings in Node.js deprecation check #1520
+157
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use dynamic property access for process.version to prevent Next.js static analysis from flagging the code as incompatible with Edge Runtime. The deprecation warning logic remains unchanged - it only runs in actual Node.js environments and is properly guarded against Edge Runtime execution. Fixes supabase#1515
Pull Request Test Coverage Report for Build 16778329417Details
💛 - Coveralls |
Maintain the original defensive programming checks while still using dynamic property access to avoid Edge Runtime warnings
- Test browser environment detection - Test Edge Runtime compatibility (no process object) - Test various process.version states (undefined, null, invalid) - Test version detection for Node.js 16, 18, 20, 22 - Test invalid version format handling
- Add export {} to make file a module
- Remove problematic test for undefined process (dependencies require it)
- Add comment explaining why Edge Runtime scenario is hard to test in Node
Use Object.defineProperty to mock only process.version instead of spreading the entire process object. This avoids copying TTY handles and other complex properties that cause Jest warnings.
grdsdev
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix - resolves Next.js Edge Runtime compatibility warnings
What is the current behavior?
The Node.js deprecation warning introduced in v2.52.1 causes Next.js Edge Runtime build warnings when using
@supabase/supabase-jsin middleware, even though the code is properly guarded and won't execute in Edge Runtime.The warnings appear as:
What is the new behavior?
This PR modifies the deprecation warning check to use dynamic property access (
process['version']) instead of direct property access (process.version). This prevents Next.js static analysis from flagging the code as incompatible with Edge Runtime while maintaining the exact same runtime behavior.Key changes:
Additional context
Testing