[lldb][NFC] Simplify Materializer/Dematerializer constructors

Teemperor · Teemperor · commit 00efeae34f22 · 2020-01-28T11:31:02.000+01:00
diff --git a/lldb/include/lldb/Expression/Materializer.h b/lldb/include/lldb/Expression/Materializer.h
@@ -22,14 +22,12 @@ namespace lldb_private {
 
 class Materializer {
 public:
-  Materializer();
+  Materializer() = default;
   ~Materializer();
 
   class Dematerializer {
   public:
-    Dematerializer()
-        : m_materializer(nullptr), m_map(nullptr),
-          m_process_address(LLDB_INVALID_ADDRESS) {}
+    Dematerializer() = default;
 
     ~Dematerializer() { Wipe(); }
 
@@ -56,11 +54,11 @@ class Materializer {
       }
     }
 
-    Materializer *m_materializer;
+    Materializer *m_materializer = nullptr;
     lldb::ThreadWP m_thread_wp;
     StackID m_stack_id;
-    IRMemoryMap *m_map;
-    lldb::addr_t m_process_address;
+    IRMemoryMap *m_map = nullptr;
+    lldb::addr_t m_process_address = LLDB_INVALID_ADDRESS;
   };
 
   typedef std::shared_ptr<Dematerializer> DematerializerSP;
@@ -128,8 +126,8 @@ class Materializer {
 
   DematerializerWP m_dematerializer_wp;
   EntityVector m_entities;
-  uint32_t m_current_offset;
-  uint32_t m_struct_alignment;
+  uint32_t m_current_offset = 0;
+  uint32_t m_struct_alignment = 8;
 };
 
 } // namespace lldb_private
diff --git a/lldb/source/Expression/Materializer.cpp b/lldb/source/Expression/Materializer.cpp
@@ -1332,9 +1332,6 @@ uint32_t Materializer::AddRegister(const RegisterInfo &register_info,
   return ret;
 }
 
-Materializer::Materializer()
-    : m_dematerializer_wp(), m_current_offset(0), m_struct_alignment(8) {}
-
 Materializer::~Materializer() {
   DematerializerSP dematerializer_sp = m_dematerializer_wp.lock();
 

Original file line number	Diff line number	Diff line change
`@@ -1332,9 +1332,6 @@ uint32_t Materializer::AddRegister(const RegisterInfo &register_info,`
`1332`	`1332`	`return ret;`
`1333`	`1333`	`}`
`1334`	`1334`
`1335`		`-Materializer::Materializer()`
`1336`		`- : m_dematerializer_wp(), m_current_offset(0), m_struct_alignment(8) {}`
`1337`		`-`
`1338`	`1335`	`Materializer::~Materializer() {`
`1339`	`1336`	`DematerializerSP dematerializer_sp = m_dematerializer_wp.lock();`
`1340`	`1337`