[Attributor][NFC] Do not record dependences on fixed attributes

jdoerfert · jdoerfert · commit 12173e60ec43 · 2019-10-30T20:44:03.000-05:00
Since fixed values cannot change, we do not need to wait for it to
happen, we will never notify the dependent attribute anyway.
diff --git a/llvm/include/llvm/Transforms/IPO/Attributor.h b/llvm/include/llvm/Transforms/IPO/Attributor.h
@@ -733,9 +733,7 @@ struct Attributor {
   /// be beneficial to avoid false dependences but it requires the users of
   /// `getAAFor` to explicitly record true dependences through this method.
   void recordDependence(const AbstractAttribute &FromAA,
-                        const AbstractAttribute &ToAA) {
-    QueryMap[&FromAA].insert(const_cast<AbstractAttribute *>(&ToAA));
-  }
+                        const AbstractAttribute &ToAA);
 
   /// Introduce a new abstract attribute into the fixpoint analysis.
   ///
@@ -907,7 +905,7 @@ struct Attributor {
     AA.update(*this);
 
     if (TrackDependence && AA.getState().isValidState())
-      QueryMap[&AA].insert(const_cast<AbstractAttribute *>(QueryingAA));
+      recordDependence(AA, const_cast<AbstractAttribute &>(*QueryingAA));
     return AA;
   }
 
@@ -929,7 +927,7 @@ struct Attributor {
             KindToAbstractAttributeMap.lookup(&AAType::ID))) {
       // Do not register a dependence on an attribute with an invalid state.
       if (TrackDependence && AA->getState().isValidState())
-        QueryMap[AA].insert(const_cast<AbstractAttribute *>(QueryingAA));
+        recordDependence(*AA, const_cast<AbstractAttribute &>(*QueryingAA));
       return AA;
     }
     return nullptr;
diff --git a/llvm/lib/Transforms/IPO/Attributor.cpp b/llvm/lib/Transforms/IPO/Attributor.cpp
@@ -4711,6 +4711,12 @@ void Attributor::initializeInformationCache(Function &F) {
   }
 }
 
+void Attributor::recordDependence(const AbstractAttribute &FromAA,
+                                  const AbstractAttribute &ToAA) {
+  if (!FromAA.getState().isAtFixpoint())
+    QueryMap[&FromAA].insert(const_cast<AbstractAttribute *>(&ToAA));
+}
+
 void Attributor::identifyDefaultAbstractAttributes(Function &F) {
   if (!VisitedFunctions.insert(&F).second)
     return;

Original file line number	Diff line number	Diff line change
`@@ -4711,6 +4711,12 @@ void Attributor::initializeInformationCache(Function &F) {`
`4711`	`4711`	`}`
`4712`	`4712`	`}`
`4713`	`4713`
	`4714`	`+void Attributor::recordDependence(const AbstractAttribute &FromAA,`
	`4715`	`+ const AbstractAttribute &ToAA) {`
	`4716`	`+ if (!FromAA.getState().isAtFixpoint())`
	`4717`	`+ QueryMap[&FromAA].insert(const_cast<AbstractAttribute *>(&ToAA));`
	`4718`	`+}`
	`4719`	`+`
`4714`	`4720`	`void Attributor::identifyDefaultAbstractAttributes(Function &F) {`
`4715`	`4721`	`if (!VisitedFunctions.insert(&F).second)`
`4716`	`4722`	`return;`