[DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets.

igorkudrin · igorkudrin · commit 2142e20f5095 · 2020-01-15T17:19:08.000+07:00
DWARFContext, the only user of this class, can already handle such offsets. Differential Revision: https://reviews.llvm.org/D71834
diff --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h
@@ -21,7 +21,7 @@ class DWARFContext;
 class DWARFDebugAranges {
 public:
   void generate(DWARFContext *CTX);
-  uint32_t findAddress(uint64_t Address) const;
+  uint64_t findAddress(uint64_t Address) const;
 
 private:
   void clear();
@@ -33,7 +33,7 @@ class DWARFDebugAranges {
 
   struct Range {
     explicit Range(uint64_t LowPC = -1ULL, uint64_t HighPC = -1ULL,
-                   uint32_t CUOffset = -1U)
+                   uint64_t CUOffset = -1ULL)
       : LowPC(LowPC), Length(HighPC - LowPC), CUOffset(CUOffset) {}
 
     void setHighPC(uint64_t HighPC) {
@@ -54,8 +54,8 @@ class DWARFDebugAranges {
     }
 
     uint64_t LowPC; /// Start of address range.
-    uint32_t Length; /// End of address range (not including this address).
-    uint32_t CUOffset; /// Offset of the compile unit or die.
+    uint64_t Length; /// End of address range (not including this address).
+    uint64_t CUOffset; /// Offset of the compile unit or die.
   };
 
   struct RangeEndpoint {
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugAranges.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDebugAranges.cpp
@@ -113,10 +113,10 @@ void DWARFDebugAranges::construct() {
   Endpoints.shrink_to_fit();
 }
 
-uint32_t DWARFDebugAranges::findAddress(uint64_t Address) const {
+uint64_t DWARFDebugAranges::findAddress(uint64_t Address) const {
   RangeCollIterator It =
       partition_point(Aranges, [=](Range R) { return R.HighPC() <= Address; });
   if (It != Aranges.end() && It->LowPC <= Address)
     return It->CUOffset;
-  return -1U;
+  return -1ULL;
 }

Original file line number	Diff line number	Diff line change
`@@ -113,10 +113,10 @@ void DWARFDebugAranges::construct() {`
`113`	`113`	`Endpoints.shrink_to_fit();`
`114`	`114`	`}`
`115`	`115`
`116`		`-uint32_t DWARFDebugAranges::findAddress(uint64_t Address) const {`
	`116`	`+uint64_t DWARFDebugAranges::findAddress(uint64_t Address) const {`
`117`	`117`	`RangeCollIterator It =`
`118`	`118`	`partition_point(Aranges, [=](Range R) { return R.HighPC() <= Address; });`
`119`	`119`	`if (It != Aranges.end() && It->LowPC <= Address)`
`120`	`120`	`return It->CUOffset;`
`121`		`- return -1U;`
	`121`	`+ return -1ULL;`
`122`	`122`	`}`