Mark llvm::ConstantExpr::getAsInstruction as const

AlexDenisov · AlexDenisov · commit 5022a5fcaef9 · 2019-11-12T14:24:12.000+01:00
Summary: getAsInstruction is the only non-const member method. It is impossible to enforce const-correctness because of it. Reviewers: jmolloy, majnemer Reviewed By: jmolloy Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70113
diff --git a/llvm/include/llvm/IR/Constants.h b/llvm/include/llvm/IR/Constants.h
@@ -1250,7 +1250,7 @@ class ConstantExpr : public Constant {
   /// which would take a ConstantExpr parameter, but that would have spread
   /// implementation details of ConstantExpr outside of Constants.cpp, which
   /// would make it harder to remove ConstantExprs altogether.
-  Instruction *getAsInstruction();
+  Instruction *getAsInstruction() const;
 
   /// Methods for support type inquiry through isa, cast, and dyn_cast:
   static bool classof(const Value *V) {
diff --git a/llvm/lib/IR/Constants.cpp b/llvm/lib/IR/Constants.cpp
@@ -3004,7 +3004,7 @@ Value *ConstantExpr::handleOperandChangeImpl(Value *From, Value *ToV) {
       NewOps, this, From, To, NumUpdated, OperandNo);
 }
 
-Instruction *ConstantExpr::getAsInstruction() {
+Instruction *ConstantExpr::getAsInstruction() const {
   SmallVector<Value *, 4> ValueOperands(op_begin(), op_end());
   ArrayRef<Value*> Ops(ValueOperands);
 

Original file line number	Diff line number	Diff line change
`@@ -3004,7 +3004,7 @@ Value ConstantExpr::handleOperandChangeImpl(Value From, Value *ToV) {`
`3004`	`3004`	`NewOps, this, From, To, NumUpdated, OperandNo);`
`3005`	`3005`	`}`
`3006`	`3006`
`3007`		`-Instruction *ConstantExpr::getAsInstruction() {`
	`3007`	`+Instruction *ConstantExpr::getAsInstruction() const {`
`3008`	`3008`	`SmallVector<Value *, 4> ValueOperands(op_begin(), op_end());`
`3009`	`3009`	`ArrayRef<Value*> Ops(ValueOperands);`
`3010`	`3010`