[LLDB] [Windows] Remove a TODO which probably won't be implemented

mstorsjo · mstorsjo · commit a42967f63c96 · 2019-10-31T11:26:06.000+02:00
Contrary to WoW64 on x86_64, there's no struct similar to WOW64_CONTEXT
defined, for storing and handling the CPU state of an ARM32 process
from an ARM64 process. Thus, making an ARM64 lldb-server able to
control ARM32 processes seems infeasible at the moment.

(The normal CONTEXT struct has a different layout on each architecture.
In addition to this, a WOW64_CONTEXT struct always is defined, that
can store the CPU state of an x86_32 process, to allow handling it from
an x86_64 process. But there's no similar universally available struct
for ARM32.)
diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp
@@ -135,8 +135,6 @@ static Status SetThreadContextHelper(lldb::thread_t thread_handle,
 std::unique_ptr<NativeRegisterContextWindows>
 NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
     const ArchSpec &target_arch, NativeThreadProtocol &native_thread) {
-  // TODO: Register context for a WoW64 application?
-
   // Register context for a native 64-bit application.
   return std::make_unique<NativeRegisterContextWindows_arm64>(target_arch,
                                                               native_thread);
