[clangd] Dont display <unknown> kinds in hover board

kadircet · kadircet · commit b08e8353a89f · 2020-01-16T11:47:00.000+01:00
Summary: Currently when hovering over an `auto` or `decltype` that resolve to a builtin-type, clangd would display `<unknown>` as the kind of the symbol. Drop that to make rendering nicer. Reviewers: usaxena95 Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D72777
diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp
@@ -522,7 +522,8 @@ markup::Document HoverInfo::present() const {
   // level 1 and 2 headers in a huge font, see
   // https://github.com/microsoft/vscode/issues/88417 for details.
   markup::Paragraph &Header = Output.addHeading(3);
-  Header.appendText(index::getSymbolKindString(Kind));
+  if (Kind != index::SymbolKind::Unknown)
+    Header.appendText(index::getSymbolKindString(Kind));
   assert(!Name.empty() && "hover triggered on a nameless symbol");
   Header.appendCode(Name);
 
diff --git a/clang-tools-extra/clangd/unittests/HoverTests.cpp b/clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -1655,7 +1655,7 @@ TEST(Hover, Present) {
             HI.Kind = index::SymbolKind::Unknown;
             HI.Name = "X";
           },
-          R"(<unknown> X)",
+          R"(X)",
       },
       {
           [](HoverInfo &HI) {

Original file line number	Diff line number	Diff line change
`@@ -1655,7 +1655,7 @@ TEST(Hover, Present) {`
`1655`	`1655`	`HI.Kind = index::SymbolKind::Unknown;`
`1656`	`1656`	`HI.Name = "X";`
`1657`	`1657`	`},`
`1658`		`- R"(<unknown> X)",`
	`1658`	`+ R"(X)",`
`1659`	`1659`	`},`
`1660`	`1660`	`{`
`1661`	`1661`	`[](HoverInfo &HI) {`