Skip to content

Commit db76588

Browse files
committed
[StringRef] Test all default characters in unit test
The default characters for trim, ltrim and rtrim are " \t\n\v\f\r" but only spaces were tested. Test that the others are trimmed as well.
1 parent d1f0bdf commit db76588

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

llvm/unittests/ADT/StringRefTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,16 +324,20 @@ TEST(StringRefTest, Trim) {
324324
StringRef Str0("hello");
325325
StringRef Str1(" hello ");
326326
StringRef Str2(" hello ");
327+
StringRef Str3("\t\n\v\f\r hello \t\n\v\f\r");
327328

328329
EXPECT_EQ(StringRef("hello"), Str0.rtrim());
329330
EXPECT_EQ(StringRef(" hello"), Str1.rtrim());
330331
EXPECT_EQ(StringRef(" hello"), Str2.rtrim());
332+
EXPECT_EQ(StringRef("\t\n\v\f\r hello"), Str3.rtrim());
331333
EXPECT_EQ(StringRef("hello"), Str0.ltrim());
332334
EXPECT_EQ(StringRef("hello "), Str1.ltrim());
333335
EXPECT_EQ(StringRef("hello "), Str2.ltrim());
336+
EXPECT_EQ(StringRef("hello \t\n\v\f\r"), Str3.ltrim());
334337
EXPECT_EQ(StringRef("hello"), Str0.trim());
335338
EXPECT_EQ(StringRef("hello"), Str1.trim());
336339
EXPECT_EQ(StringRef("hello"), Str2.trim());
340+
EXPECT_EQ(StringRef("hello"), Str3.trim());
337341

338342
EXPECT_EQ(StringRef("ello"), Str0.trim("hhhhhhhhhhh"));
339343

0 commit comments

Comments
 (0)