fix: properly clean up component lifecycle order issue

fabhari · fabhari · commit 00819509e561 · 2025-08-28T19:59:25.000+01:00
- move effect cleanup to happen before new creation in key function
- ensure proper lifecycle order. destroy old component -&gt; create new component
- so now the order is script -&gt; mount -&gt; abort -&gt; destroy -&gt; script -&gt; mount
diff --git a/.changeset/chilled-donkeys-ring.md b/.changeset/chilled-donkeys-ring.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: fixed component lifecycle timing issue in #key blocks. its now properly cleaned up before new instance are created.
diff --git a/packages/svelte/src/internal/client/dom/blocks/key.js b/packages/svelte/src/internal/client/dom/blocks/key.js
@@ -25,7 +25,7 @@ export function key(node, get_key, render_fn) {
 	/** @type {V | typeof UNINITIALIZED} */
 	var key = UNINITIALIZED;
 
-	/** @type {Effect} */
+	/** @type {Effect | null} */
 	var effect;
 
 	/** @type {Effect} */
@@ -37,10 +37,6 @@ export function key(node, get_key, render_fn) {
 	var changed = is_runes() ? not_equal : safe_not_equal;
 
 	function commit() {
-		if (effect) {
-			pause_effect(effect);
-		}
-
 		if (offscreen_fragment !== null) {
 			// remove the anchor
 			/** @type {Text} */ (offscreen_fragment.lastChild).remove();
@@ -54,6 +50,12 @@ export function key(node, get_key, render_fn) {
 
 	block(() => {
 		if (changed(key, (key = get_key()))) {
+			// Pause and cleanup the old effect before creating a new one
+			// This ensures proper component lifecycle ordering (destroy -> create -> mount)
+			if (effect) {
+				pause_effect(effect);
+				effect = null;
+			}
 			var target = anchor;
 
 			var defer = should_defer_append();
@@ -63,6 +65,7 @@ export function key(node, get_key, render_fn) {
 				offscreen_fragment.append((target = create_text()));
 			}
 
+			// Create the new effect with the component
 			pending_effect = branch(() => render_fn(target));
 
 			if (defer) {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: fixed component lifecycle timing issue in #key blocks. its now properly cleaned up before new instance are created.