tweak test logic to reduce false negatives

Rich-Harris · Rich-Harris · commit 0a61c80be3a7 · 2025-06-23T06:50:10.000-04:00
diff --git a/packages/svelte/src/compiler/print/index.js b/packages/svelte/src/compiler/print/index.js
@@ -16,7 +16,7 @@ export function print(ast) {
 	});
 }
 
-/** @type {Visitors<AST.SvelteNode, any>} */
+/** @type {Visitors<AST.SvelteNode>} */
 const visitors = {
 	Root(node, context) {
 		if (node.options) {
diff --git a/packages/svelte/tests/parser-modern/test.ts b/packages/svelte/tests/parser-modern/test.ts
@@ -49,26 +49,51 @@ const { test, run } = suite<ParserTest>(async (config, cwd) => {
 
 		fs.writeFileSync(`${cwd}/_actual.svelte`, printed.code);
 
-		const actual_cleaned = walk(actual, null, {
-			_(node, context) {
-				delete node.loc;
-				context.next();
-			}
-		});
-
 		delete reparsed.comments;
 
-		const reparsed_cleaned = walk(reparsed, null, {
-			_(node, context) {
-				delete node.loc;
-				context.next();
-			}
-		});
-
-		assert.deepEqual(actual_cleaned, reparsed_cleaned);
+		assert.deepEqual(clean(actual), clean(reparsed));
 	}
 });
 
+function clean(ast: import('svelte/compiler').AST.SvelteNode) {
+	return walk(ast, null, {
+		_(node, context) {
+			// @ts-ignore
+			delete node.start;
+			// @ts-ignore
+			delete node.end;
+			// @ts-ignore
+			delete node.loc;
+			// @ts-ignore
+			delete node.leadingComments;
+			// @ts-ignore
+			delete node.trailingComments;
+
+			context.next();
+		},
+		Fragment(node, context) {
+			return {
+				...node,
+				nodes: node.nodes
+					.map((child, i) => {
+						if (child.type === 'Text') {
+							if (i === 0) {
+								child = { ...child, data: child.data.trimStart() };
+							}
+
+							if (i === node.nodes.length - 1) {
+								child = { ...child, data: child.data.trimEnd() };
+							}
+
+							if (!child.data) return null;
+						}
+					})
+					.filter(Boolean)
+			};
+		}
+	});
+}
+
 export { test };
 
 await run(__dirname);

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export function print(ast) {`
`16`	`16`	`});`
`17`	`17`	`}`
`18`	`18`
`19`		`-/** @type {Visitors<AST.SvelteNode, any>} */`
	`19`	`+/** @type {Visitors<AST.SvelteNode>} */`
`20`	`20`	`const visitors = {`
`21`	`21`	`Root(node, context) {`
`22`	`22`	`if (node.options) {`