fix: Allow to disable animation prefix (#14822)

ai · paoloricciuti · web-flow · commit 38a3ae321ffc · 2024-12-24T13:16:03.000+01:00
* fix: Allow to disable animation prefix

* Apply suggestions from code review

---------

Co-authored-by: Paolo Ricciuti &lt;ricciutipaolo@gmail.com&gt;
diff --git a/.changeset/twenty-shoes-peel.md b/.changeset/twenty-shoes-peel.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: don't include keyframes in global scope in the keyframes to rename
diff --git a/packages/svelte/src/compiler/phases/2-analyze/css/css-analyze.js b/packages/svelte/src/compiler/phases/2-analyze/css/css-analyze.js
@@ -28,11 +28,19 @@ function is_global_block_selector(simple_selector) {
 	);
 }
 
+/**
+ *
+ * @param {Array<AST.CSS.Node>} path
+ */
+function is_in_global_block(path) {
+	return path.some((node) => node.type === 'Rule' && node.metadata.is_global_block);
+}
+
 /** @type {CssVisitors} */
 const css_visitors = {
 	Atrule(node, context) {
 		if (is_keyframes_node(node)) {
-			if (!node.prelude.startsWith('-global-')) {
+			if (!node.prelude.startsWith('-global-') && !is_in_global_block(context.path)) {
 				context.state.keyframes.push(node.prelude);
 			}
 		}
diff --git a/packages/svelte/tests/css/samples/global-block/expected.css b/packages/svelte/tests/css/samples/global-block/expected.css
@@ -74,6 +74,10 @@
 			animation: svelte-xyz-test 1s;
 		}
 
+		.y{
+			animation: test-in 1s;
+		}
+
 		@keyframes test-in{
 			to{
 				opacity: 1;
diff --git a/packages/svelte/tests/css/samples/global-block/input.svelte b/packages/svelte/tests/css/samples/global-block/input.svelte
@@ -76,6 +76,10 @@
 			animation: test 1s;
 		}
 
+		.y{
+			animation: test-in 1s;
+		}
+
 		@keyframes test-in{
 			to{
 				opacity: 1;

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: don't include keyframes in global scope in the keyframes to rename